trilbymedia / grav-plugin-flex-objects

Powerful and supremely flexible object support for Grav
MIT License
40 stars 10 forks source link

Git-sync: Disable automatic page sync #120

Closed w00fz closed 3 years ago

w00fz commented 3 years ago

ard on discord mentioned the setting being ignored even if disabled and saving still syncing unexpectedly.

arifrifai commented 3 years ago

Yes, I did, thanks to raise this issue. I set sync on_save: false but it is always synced.

enabled: true
folders:
  - pages
  - custom/shortcodes
sync:
  on_save: false
  on_delete: false
  on_media: false
  cron_enable: false
axonasif commented 3 years ago

And I was thinking it's an issue with my messy setup itself. Glad I'm not alone :joy: Hoping this bug getting patched soon...

w00fz commented 3 years ago

Sorry for the wait, I hope some time next week to be able to get to this issue!

Cheers

preraksola commented 3 years ago

I am facing the same issue. I have a pipeline configured to my git repository. On every save a new build is being triggered which is not useful and is consuming resources. Could you please provide an update on this issue? Thanks.

w00fz commented 3 years ago

@mahagr can you take a quick look and see if anything stands out? I believe this is related to Flex Pages and 1.7/1.10 , perhaps something not backward compatible is causing this issue.

Cheers

mahagr commented 3 years ago

Yeah, we run gitsync manually from flex as it doesn't call the admin event unless it's saving a page.

mahagr commented 3 years ago

@arifrifai @AXIM0S @preraksola Should be fixed in the next version of flex plugin.