search

trilbymedia / grav-plugin-git-sync

Collaboratively Synchronize your Grav `user` folder hosted on GitHub, BitBucket or GitLab
Apache License 2.0
243 stars 58 forks source link

The "Edit this page" address for TFS is wrong #87

Closed amiram closed 6 years ago

amiram commented 6 years ago

The regular link to adit a page is http://[repo-address]/blob/master/pages/folder/docs.md

For tfs it should be: http://[repo-address]?path=%2Fpages%2Ffolder%2Fdocs.md&_a=contents

If it is not on the master branch, branch name should be added with GB prefix. For branch dev: http://[repo-address]?path=%2Fpages%2Ffolder%2Fdocs.md&_a=contents&version=GBdev

paulhibbitts commented 6 years ago

Hi @amiram , by the sounds of it this is an issue with one of my themes that automatically creates an "Edit this Page" link for use with the Git Sync Plugin (Open Course Hub, Learn2 with Git Sync, and Open Publishing Space)? I've only done testing with standard GitHub, GitLab, and Bitbucket repositories. I have no experience with TFS.

All of the logic is actually handled by the theme, so customizations are possible. If you would like to further discuss please leave an issue on the appropriate theme repo or connect with me in the Grav Slack room (https://getgrav.org/slack), thanks.

amiram commented 6 years ago

Thanks. I'll close this too and look in the learn2 repo.