trilbymedia / grav-plugin-login-ldap

Grav LDAP login plugin
https://trilby.media
MIT License
10 stars 13 forks source link

Ignore authentication requests with empty username #14

Closed chhemme closed 4 years ago

chhemme commented 4 years ago

When using login-ldap with the admin panel I get an LDAP exception because the query is invalid. It looks like the plugin sends an empty login request when loading the admin login page. This causes an invalid query.

rhukster commented 4 years ago

Thanks!

mloitm commented 4 years ago

Is there a new release planned with this change included? We are currently using develop branch, but it would be nice to have an official release.

rhukster commented 4 years ago

Yes, does look like we need to get a release out with this PR. Added it to my list of things.

ghost commented 3 years ago

I had the same error message when any user logout from admin pannel (which I documented in #15).

I've patched the plugin with the content of the commit listed above and it fixed the proble.