search

trilbymedia / grav-plugin-login-oauth2

OAuth2 Client Plugin to integrate with Grav's Login
https://trilby.media
MIT License
17 stars 15 forks source link

Feature Request: The addition of Keycloak support or user defined provider #23

Open mannp opened 5 years ago

mannp commented 5 years ago

Hi there

Thanks for your consideration.

This is the link for Keycloak support via the League/oauth2-client

-> https://github.com/stevenmaguire/oauth2-keycloak

chhemme commented 2 years ago

Any Feedback on this?

ozfox commented 2 years ago

I wanted to answer on this since a while, so thank you @chhemme for motivating me. I was looking for the Keycloak support a while ago and ended up with forking grav-plugin-login-oauth2-extras and adding a custom Keycloak provider. It does actually use the library mentioned in the original post.

It works stable in my specific usecase since a while but I never found the time to implement all functionality or clean it up. Unfortunately my time to work on this is limited right now but I can at least publish my effort and create a PR. Maybe someone can pick it up or the maintainers can point out what's missing.

Won't happen this week I guess, but I'll try.

chhemme commented 2 years ago

Thanks @ozfox That would be great if you could create PR when you find time for it.

ozfox commented 2 years ago

The Keycloak support was implemented with the merge request Add Keycloak support #5 of the grav-plugin-login-oauth2-extras plugin. All credit goes to @andreasgrill, I am just referencing this here.

What's meant with "user defined provider" is not clear to me, I guess this already possible with the current API and is exactly what the grav-plugin-login-oauth2-extras plugin is doing?!

Guess this can be closed if a new version of login-oauth2-extras is released.

mannp commented 2 years ago

It means any other oidc compatible provider.

I no longer use grav, so this can be closed for me, or left open to track the item?