trilbymedia / grav-plugin-login-oauth2

OAuth2 Client Plugin to integrate with Grav's Login
https://trilby.media
MIT License
18 stars 15 forks source link

GuzzleHttp version conflicting with other plugins for lack of centralized libraries #41

Open drzraf opened 3 years ago

drzraf commented 3 years ago

I would like to bring your attention on https://github.com/stephan-strate/grav-plugin-logger-channels/issues/4

Both do return require __DIR__ . '/vendor/autoload.php'; (and corresponding spl_autoload_register with different entries for GuzzleHttp) in a first-win fashion which make both plugins de facto incompatibles.

I'm pretty sure it's not the first time such an issue arise since it's deemed to happen if each plugin manages its own set of dependencies (which are likely redundant across a Grav installation).

mahagr commented 3 years ago

Yes, this is the downside of plugins using vendor libraries. Sometimes they even conflict with Grav itself.