search

trilbymedia / grav-theme-bootstrap4

MIT License
14 stars 5 forks source link

Inconsistent use of theme variables #8

Open asafpm opened 5 years ago

asafpm commented 5 years ago

In templates/partials/navigation.html.twig the theme variables are used inconsistently. For example at the top of the file there is 

{% set navbar_style = theme_var('navbar_style') %}
{% set navbar_bgcolor = theme_var('navbar_bgcolor') %}

while another theme variable is used as:

config.themes.bootstrap4.dropdown.enabled

This creates problems when making inherited themes based on bootstrap4 because navbar_style and navbar_bgcolor are loaded from the inherited theme while config.themes.bootstrap4.dropdown.enabled is loaded from the parent bootstrap4 theme.

mfi-teresa commented 4 years ago

submitted PR to fix this (surprised no one else has) - change config.themes.bootstrap4.dropdown.enabled to theme.dropdown.enabled and it fixes.