search

trilemma-dev / SecureXPC

A simple and secure XPC framework for Swift
MIT License
75 stars 15 forks source link

Factors out XPC server message acceptance logic #39

Closed jakaplan closed 2 years ago

jakaplan commented 2 years ago

Factors out the security logic into a SecureMessageAcceptor struct.

Resolves #36

jakaplan commented 2 years ago

@amomchilov when you have the time, would appreciate you taking a look. I went with a compositional approach over inheritance as it seemed simpler to me.

amomchilov commented 2 years ago

Meta point: I would suggest:

  1. You make the PR title more useful, to make it more clear when it shows up. E.g., this is part of my GitHub inbox:

    Screen Shot 2022-01-09 at 2 06 45 PM

    Perhaps "Factor out SecureMessageAcceptor"?

  2. Use one of the recognized keywords (listed here) in the PR description, to make GitHub automatically link this PR to the issue. E.g. Resolves #36.