trilemma-dev / SecureXPC

A simple and secure XPC framework for Swift
MIT License
75 stars 15 forks source link

Fix missing dispatch queue setting #44

Closed jakaplan closed 2 years ago

jakaplan commented 2 years ago

I realized this while working on #43, but wanted to address it separately

jakaplan commented 2 years ago

@amomchilov unless I overlooked something this should be a real quick review

jakaplan commented 2 years ago

Adding tests for this would be nice.

Hmm, I'll have to give some thought on how to do this. I'd want to assert that the server handlers are running on threads belonging to the dispatch queue I created?

Not sure how to test that the listener connection is properly using the dispatch queue, as that's quite internal to the servers.