search

trilemma-dev / SecureXPC

A simple and secure XPC framework for Swift
MIT License
75 stars 15 forks source link

Removes references to "service" in conjunction with "anonymous" #48

Closed jakaplan closed 2 years ago

jakaplan commented 2 years ago

Anonymous connections have no service, which is a key distinguishing factor from XPC Services and Mach services.

jakaplan commented 2 years ago

@amomchilov Onboard with this? It's a change to terminology, there's no change to functionality in this PR.

amomchilov commented 2 years ago

(Continued from this thread)

Yes you're correct, but my point was that the name XPCAnonymousClient makes it sound like an "an anonymous client" not "the client of an anonymous service".

Perhaps there should be a little blurb in the API doc that clarifies that.

But overall, I think the new name is fine

jakaplan commented 2 years ago

Perhaps there should be a little blurb in the API doc that clarifies that.

Do you mean in the public API doc? XPCAnonymousClient isn't part of the public API. From an API user's point of view the way to create a client which talks with an anonymous server is unchanged by the PR and remains XPCClient.forEndpoint(...).

The internal documentation currently states:

A concrete implementation of XPCClient which can communicate with an anonymous XPC listener connection.

Is there some additional documentation you'd find helpful? More than happy to expand upon it; if you haven't already gathered I'm a big fan of documentation.

amomchilov commented 2 years ago

A concrete implementation of XPCClient which can communicate with an anonymous XPC listener connection.

Oh I didn't notice that was already. That's perfect, and exactly what I had in mind. 👍