search

trilemma-dev / SecureXPC

A simple and secure XPC framework for Swift
MIT License
75 stars 15 forks source link

Removes `endpoint` from `XPCServer` as it can't be supported by `XPCServicesServer` #50

Closed jakaplan closed 2 years ago

jakaplan commented 2 years ago

Fixes #46

NonBlockingStartable has been renamed to NonBlockingServer and endpoint was added to it. Not sure this is the best name for the protocol, but good enough for putting this up for review.

jakaplan commented 2 years ago

@amomchilov for your review

amomchilov commented 2 years ago

re: https://github.com/trilemma-dev/SecureXPC/issues/46#issuecomment-1011788484

I think you should document this finding somewhere in the implementation, because it's not obvious that this shouldn't work.

jakaplan commented 2 years ago

re: #46 (comment)

I think you should document this finding somewhere in the implementation, because it's not obvious that this shouldn't work.

Good point, will do!