search

trilemma-dev / SecureXPC

A simple and secure XPC framework for Swift
MIT License
75 stars 15 forks source link

Makes `XPCServerEndpoint` conform to `Codable` #53

Closed jakaplan closed 2 years ago

jakaplan commented 2 years ago

Fixes #12

Encoding and decoding "cheats" by using specific functions custom to XPCEncoderImpl and XPCDecoderImpl. As such if any other encoder or decoder tried to make use of these an error will be thrown.

Added two simple roundtrip tests to verify encoding and decoding works as expected for the anonymous server. However, this is a pretty limited test as it doesn't actually send the endpoint over an XPC connection.

jakaplan commented 2 years ago

@amomchilov thoughts? I know you were the one to originally propose doing this so, let me know if this is along the lines of what you had in mind.

amomchilov commented 2 years ago

It's been a while since I've worked with the implementation of the encoder and decoder, and this is flying way over my head right now haha.

I'm struggling to review it just from GitHub. I'll try to follow up on this over the weekend. I'll need to actually open this open locally and browse around to regain some context.

jakaplan commented 2 years ago

I'm struggling to review it just from GitHub. I'll try to follow up on this over the weekend. I'll need to actually open this open locally and browse around to regain some context.

No worries, I completely understand. Once this is merged, I think we'll be ready to make the anonymous server public along with updated documentation.