search

trilemma-dev / SecureXPC

A simple and secure XPC framework for Swift
MIT License
75 stars 15 forks source link

Renames `route` parameter to `toRoute` for `send` functions #77

Closed jakaplan closed 2 years ago

jakaplan commented 2 years ago

This is done to align with Swift's API Guidelines that state, "Prefer method and function names that make use sites form grammatical English phrases."

The toRoute parameter is always the first or second parameter, which makes it quite important. As the guidelines further state, "It is acceptable for fluency to degrade after the first argument or two when those arguments are not central to the call’s meaning."

There are no functional changes to this PR, just a naming change. Of course this is a breaking change.

jakaplan commented 2 years ago

@amomchilov Just wanted to flag this PR to you since it's a breaking change. Otherwise this PR isn't interesting and so I'm going to merge it without review.