trilemma-dev / SecureXPC

A simple and secure XPC framework for Swift
MIT License
73 stars 15 forks source link

Auto-detection of server and client types for most common cases #98

Closed jakaplan closed 2 years ago

jakaplan commented 2 years ago

This introduces full auto-detection for common server types. For clients, specifying the name of the service will still be needed, but the caller won't in most cases need to know whether they're calling an XPC service or an XPC Mach service.

jakaplan commented 2 years ago

So far only the server portion of this has been implemented. The client section is still functional as-is, but it'd be quite confusing to use (and much of the documentation no longer makes sense). An update to this PR will be forthcoming that adds the client portion.

jakaplan commented 2 years ago

@amomchilov available for you to review if you'd like to do so

amomchilov commented 2 years ago

Hey Josh, I'd love to review, but I'm currently sick. Don't wait on me, but I'll provide feedback to merge in later, if any

jakaplan commented 2 years ago

Oh no, hope you start feeling better soon!

amomchilov commented 2 years ago

It took a few days, but I am! Covid sucks.

This PR has quite a bit going on, and I'm having troubling understanding the changes. Could you provide me some more context?

jakaplan commented 2 years ago

It took a few days, but I am! Covid sucks.

Yeah it really does. I had it a couple months ago, it was no fun at all.

This PR has quite a bit going on, and I'm having troubling understanding the changes. Could you provide me some more context?

Sorry, in retrospect I could've split this up into a few different PRs. There are three main pieces here:

jakaplan commented 2 years ago

@amomchilov I've made changes based on your feedback and added all the parts to this PR (sorry there are so many, will aim for smaller PRs in the future) that I had envisioned

jakaplan commented 2 years ago

I'm going to go ahead and merge this, but happy to receive further feedback on this PR