search

trilinos / Trilinos

Primary repository for the Trilinos Project
https://trilinos.org/
Other
1.19k stars 565 forks source link

Ifpack2: native RILUK implementation is not UVM-free #10217

Open jhux2 opened 2 years ago

jhux2 commented 2 years ago

Enhancement

@trilinos/ifpack2 @csiefer2 @srajama1 @vqd8a

Ifpack2's native implementation of RILUK depends on UVM if compiled for CUDA. Some of the associated unit tests have been modified to return early to avoid this issue, e.g., Ifpack2_UnitTestSingleProcessRILUK.cpp around line 448.

There are a few ways to address this: 1) Refactor the native RILUK code to remove dependencies on UVM. 2) Always use the iterative SPILUK algorithm in Kokkos-Kernels and delete the native RILUK. 3) Only allow the native RILUK class to be built and used on host, otherwise use SPILUK in Kokkos-Kernels.

Are there other options? What are people's thoughts?

github-actions[bot] commented 1 year ago

This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity. If you would like to keep this issue open please add a comment and/or remove the MARKED_FOR_CLOSURE label. If this issue should be kept open even with no activity beyond the time limits you can add the label DO_NOT_AUTOCLOSE. If it is ok for this issue to be closed, feel free to go ahead and close it. Please do not add any comments or change any labels or otherwise touch this issue unless your intention is to reset the inactivity counter for an additional year.

github-actions[bot] commented 1 year ago

Automatic mention of the @trilinos/ifpack2 team