trilinos / Trilinos

Primary repository for the Trilinos Project
https://trilinos.org/
Other
1.21k stars 567 forks source link

Framework: #10648 deletes necessary files #11101

Closed dridzal closed 1 year ago

dridzal commented 2 years ago

Bug Report

@trilinos/framework

Description

The checkin test script, cmake/std/sems/checkin-test-sems.sh, used, for instance, by @trilinos/rol for the two-way repo merge, no longer works due to #10648 and related commits. It appears that the cmake files required for configure/test have been removed without consideration of consequences.

Steps to Reproduce

Run the checkin test script. It will fail with

-- Reading in configuration options from cmake/std/GCC-4.8.4-OpenMPI-1.10.1-MpiReleaseDebugSharedPtOpenMP.cmake ...
CMake Error at cmake/tribits/core/package_arch/TribitsGlobalMacros.cmake:180 (include):
  include could not find load file:

    cmake/std/GCC-4.8.4-OpenMPI-1.10.1-MpiReleaseDebugSharedPtOpenMP.cmake
e10harvey commented 2 years ago

Filed https://sems-atlassian-son.sandia.gov/jira/servicedesk/customer/portal/7/TRILINOSHD-215.

bartlettroscoe commented 2 years ago

@dridzal, the solution is to upgrade the checkin-tests-sems.sh script to use the GenConfig system. That is a much more complex system (e.g. having to run a separate script to get needed files, symlinks getting created, etc.) but it works and it is supported by the Trilinos framework team.

Let's schedule a time later this week to go over what needs to be done. It should not take long to get your sync process updated to use a GenConfig configuration.

dridzal commented 2 years ago

@bartlettroscoe: Can we do anything right away? We are looking at some time-sensitive deliveries. Can we just back out the changes that remove the necessary files?

bartlettroscoe commented 2 years ago

Can we do anything right away?

@dridzal, you could, just this one time, cross your fingers and manually do the sync each way, perhaps with just a local build of ROL using any approach that your team is already using to sync from the main repo to your ROL repo and rely on the PR builds for syncing from your ROL repo back to the main Trilinos repo.

Otherwise, updating checkin-test-sems.sh to use a GenConfig PR build should not be very hard.

github-actions[bot] commented 1 year ago

This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity. If you would like to keep this issue open please add a comment and/or remove the MARKED_FOR_CLOSURE label. If this issue should be kept open even with no activity beyond the time limits you can add the label DO_NOT_AUTOCLOSE. If it is ok for this issue to be closed, feel free to go ahead and close it. Please do not add any comments or change any labels or otherwise touch this issue unless your intention is to reset the inactivity counter for an additional year.

github-actions[bot] commented 1 year ago

This issue was closed due to inactivity for 395 days.