trilinos / Trilinos

Primary repository for the Trilinos Project
https://trilinos.org/
Other
1.19k stars 565 forks source link

Trilinos installs googletest #11271

Open yurivict opened 1 year ago

yurivict commented 1 year ago

Bug Report

$ sudo pkg add -A /usr/local/poudriere/data/packages/13amd64-local-workstation/.real_1668289520/All/trilinos-13.4.1.pkg
Installing trilinos-13.4.1...
pkg: trilinos-13.4.1 conflicts with googletest-1.12.1 (installs files into the same place).  Problematic file: /usr/local/include/gtest/gtest.h

Description

There is no need to install googletest. 1) it is already present as a package 2) it shouldn't be required in the runtime

Trilinos should use externally installed googletest when needed.

GrahamBenHarper commented 1 year ago

Hm, this may be @jwillenbring's territory?

mayrmt commented 1 year ago

@yurivict You can tell Trilinos to not install googletest via the following CMake option: -D Trilinos_ENABLE_Gtest:BOOL=OFF

jhux2 commented 1 year ago

Extensive discussion of this in #8001.

github-actions[bot] commented 6 months ago

This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity. If you would like to keep this issue open please add a comment and/or remove the MARKED_FOR_CLOSURE label. If this issue should be kept open even with no activity beyond the time limits you can add the label DO_NOT_AUTOCLOSE. If it is ok for this issue to be closed, feel free to go ahead and close it. Please do not add any comments or change any labels or otherwise touch this issue unless your intention is to reset the inactivity counter for an additional year.

yurivict commented 6 months ago

Not stale.

thierry-FreeBSD commented 3 months ago

@yurivict The problematic file should not be used by the consumers of Trilinos: I suggest to just remove it from the staging directory. To be sure, you could add a runtime dependency on Google test, so that the file will be available (but I don't think it is really necessary).