search

trilinos / Trilinos

Primary repository for the Trilinos Project
https://trilinos.org/
Other
1.2k stars 564 forks source link

MueLu, Xpetra, Thyra: HAVE_MUELU_THYRA does not enable when Thyra is enabled by another package #11425

Closed GrahamBenHarper closed 7 months ago

GrahamBenHarper commented 1 year ago

Bug Report

@trilinos/muelu @trilinos/thyra @bartlettroscoe

When removing packages from my configure scripts related to the now optional Epetra dependency in Panzer, I noticed it was possible for PanzerAdaptersSTK to enable ThyraCore at configure time, but when MueLu configures and checks for Thyra it does not detect Thyra. However, MueLu will attempt to build the Thyra adapters because Thyra is enabled, which then causes the build to fail. This is why I originally opened #11424.

I've attached the relevant configure script and configure log. Commit SHA 6e32b9b, or the develop head. configure-nightly-trilinos-MrHyDE.txt trilinos_configure.log

The highlights from the configure log are the following: -- Setting Trilinos_ENABLE_ThyraCore=ON because PanzerDiscFE has a required dependence on ThyraCore -- Setting Trilinos_ENABLE_ThyraTpetraAdapters=ON because PanzerDiscFE has a required dependence on ThyraTpetraAdapters -- NOT setting Xpetra_ENABLE_Thyra=ON since Thyra is NOT enabled at this point! -- NOT setting MueLu_ENABLE_Thyra=ON since Thyra is NOT enabled at this point!

Final set of enabled top-level packages:  Gtest Kokkos Teuchos KokkosKernels RTOp Sacado Zoltan Shards Tpetra TrilinosSS Thyra Xpetra Galeri Pamgen Zoltan2Core Belos Amesos2 SEACAS Ifpack2 Stratimikos Intrepid2 Compadre STK Phalanx NOX MueLu Rythmos ROL Piro Panzer 30

Final set of enabled packages:  Gtest KokkosCore KokkosContainers KokkosAlgorithms Kokkos TeuchosCore TeuchosParser TeuchosParameterList TeuchosComm TeuchosNumerics TeuchosRemainder TeuchosKokkosCompat TeuchosKokkosComm Teuchos KokkosKernels RTOp Sacado Zoltan Shards TpetraCore Tpetra TrilinosSS ThyraCore ThyraTpetraAdapters Thyra Xpetra Galeri Pamgen Zoltan2Core Belos Amesos2 SEACASExodus SEACASExodus_for SEACASExoIIv2for32 SEACASNemesis SEACASIoss SEACASChaco SEACASAprepro_lib SEACASSupes SEACASSuplib SEACASSuplibC SEACASSuplibCpp SEACASSVDI SEACASPLT SEACASAlgebra SEACASAprepro SEACASBlot SEACASConjoin SEACASEjoin SEACASEpu SEACASCpup SEACASExo2mat SEACASExodiff SEACASExomatlab SEACASExotxt SEACASExo_format SEACASEx1ex2v2 SEACASFastq SEACASGjoin SEACASGen3D SEACASGenshell SEACASGrepos SEACASExplore SEACASMapvarlib SEACASMapvar SEACASMapvar-kd SEACASMat2exo SEACASNas2exo SEACASZellij SEACASNemslice SEACASNemspread SEACASNumbers SEACASSlice SEACASTxtexo SEACASEx2ex1v2 SEACAS Ifpack2 Stratimikos Intrepid2 Compadre STKUtil STKCoupling STKMath STKSimd STKNGP_TEST STKTopology STKMesh STKIO STKSearch STKTransfer STKTools STKBalance STKUnit_test_utils STKSearchUtil STKUnit_tests STKDoc_tests STKExprEval STKEmend STK Phalanx NOX MueLu Rythmos ROL Piro PanzerCore PanzerDofMgr PanzerDiscFE PanzerAdaptersSTK Panzer 110

Final set of non-enabled top-level packages:  TrilinosFrameworkTests TrilinosATDMConfigTests MiniTensor Epetra Triutils EpetraExt Domi Isorropia Pliris AztecOO Amesos Ifpack ML ShyLU_Node Komplex Anasazi FEI Teko TriKota Intrepid Percept Krino Moertel Zoltan2Sphynx Zoltan2 ShyLU_DD ShyLU Tempus Stokhos PyTrilinos NewPackage Adelus TrilinosCouplings Pike TrilinosBuildStats TrilinosInstallTests 36

Final set of non-enabled packages:  TrilinosFrameworkTests TrilinosATDMConfigTests KokkosSimd MiniTensor Epetra Triutils EpetraExt TpetraTSQR Domi ThyraEpetraAdapters ThyraEpetraExtAdapters Isorropia Pliris AztecOO Amesos Ifpack ML ShyLU_NodeHTS ShyLU_NodeTacho ShyLU_NodeBasker ShyLU_NodeFastILU ShyLU_Node SEACASExotec2 Komplex Anasazi FEI Teko TriKota Intrepid Percept Krino Moertel Zoltan2Sphynx Zoltan2 ShyLU_DDFROSch ShyLU_DDCore ShyLU_DDCommon ShyLU_DD ShyLU Tempus Stokhos PanzerMiniEM PanzerExprEval PyTrilinos NewPackage Adelus TrilinosCouplings PikeBlackBox PikeImplicit Pike TrilinosBuildStats TrilinosInstallTests 52
github-actions[bot] commented 1 year ago

Automatic mention of the @trilinos/muelu team

github-actions[bot] commented 1 year ago

Automatic mention of the @trilinos/muelu team

github-actions[bot] commented 1 year ago

Automatic mention of the @trilinos/muelu team

github-actions[bot] commented 1 year ago

Automatic mention of the @trilinos/muelu team

github-actions[bot] commented 1 year ago

Automatic mention of the @trilinos/muelu team

bartlettroscoe commented 1 year ago

Hello @GrahamBenHarper, the dependency handling system is working just fine in TriBITS and in Trilinos. Given the fact:

So, the Thyra parent package does not get enabled in the dependency sweeps, only, ThyraCore and ThyraAdapters due to required (indirect) dependencies of explicitly enabled packages. You can see this in the configure output:

Enabling all required upstream packages for current set of enabled packages (Trilinos_ENABLE_SECONDARY_TESTED_CODE=ON) ...

...
-- Setting Trilinos_ENABLE_ThyraCore=ON because PanzerDiscFE has a required dependence on ThyraCore
-- Setting Trilinos_ENABLE_ThyraTpetraAdapters=ON because PanzerDiscFE has a required dependence on ThyraTpetraAdapters
...

... because Thyra is enabled ...

Note that the Thyra package is not really being enabled here, just the shell of it as described in:

which says:

In these cases where one of a parent package’s subpackages is enabled for some reason, the final value of ${PROJECT_NAME}_ENABLE_${PACKAGE_NAME} will be set to ON (but this does imply that all of the required subpackages will be enabled, only that the parent package will be processed.)

You can see this in the configure output:

Enabling the shell of non-enabled parent packages (mostly for show) that have at least one subpackage enabled ...

-- Setting Trilinos_ENABLE_Thyra=ON because Trilinos_ENABLE_ThyraCore=ON
-- Setting Thyra_ENABLE_ThyraCore=ON because Trilinos_ENABLE_ThyraCore=ON
-- Setting Thyra_ENABLE_ThyraTpetraAdapters=ON because Trilinos_ENABLE_ThyraTpetraAdapters=ON

Note that this happens at the very end, and therefore can't trigger the enable of MueLu_ENABLE_Thyra.

I know this is a bit confusing but it was more confusing for people when they saw that one or more of a parent package's subpackages was enabled but not the parent package itself. (Just one of the several added complexities of supporting subpackages.)

However, MueLu will attempt to build the Thyra adapters because Thyra is enabled, which then causes the build to fail.

This sounds like a defect in the MueLu CMakeLists.txt files. I should be able to reproduce this and put in a PR to fix this (in MueLu where the problem likely exists).

GrahamBenHarper commented 1 year ago

Thanks @bartlettroscoe!

Thyra was not explicitly enabled on input Support for Thyra in MueLu is only optional -D Trilinos_ENABLE_ALL_OPTIONAL_PACKAGES:BOOL=OFF is set

It's true that this could be simply fixed by manually enabling Thyra in the configure script, but what worried me most is just the fact that I was doing what I thought was reasonable pruning of package enablement lines in my Trilinos configure when I came across this situation.

Enabling the shell of non-enabled parent packages (mostly for show) that have at least one subpackage enabled ...

Oh, I understand what that means now. What about the case where a package like Thyra only has one core subpackage? In this case, I would argue that while it says its enabling the shell of Thyra, ThyraCore is the only "main" part of Thyra. Does that mean in some cases it's more correct to check for subpackage enablement as opposed to parent package enablement?

This sounds like a defect in the MueLu CMakeLists.txt files. I should be able to reproduce this and put in a PR to fix this (in MueLu where the problem likely exists).

That was my second guess if my idea in that PR didn't work. Please note that Xpetra also has similar issues, as Xpetra also does not build ThyraUtils when using the provided configuration. I suspect it's for the same reason as MueLu's errors. Would setting both packages to check for ThyraCore work?

bartlettroscoe commented 1 year ago

@GrahamBenHarper, a simple attempt to reproduce this error seems to have failed (i.e. MueLu with Tpetra and ThyraCore eanbled but with Epetra and Thyra disabled builds just fine for me). (I will post those results to CDash shortly.)

Can you please post what the build error(s) you are seeing looks like?

In the meantime, I will try to match the exact set of package enables and disables shown above.

bartlettroscoe commented 1 year ago

Is this still an issue?

cgcgcg commented 1 year ago

@GrahamBenHarper

GrahamBenHarper commented 1 year ago

Yes, this is still an issue on develop SHA 47270b7bdee8833b10fd5d00a4a16cecb36e160e. Here's the relevant build error that I'm seeing.

[5491/5962] Building CXX object packages/muelu/adapters/CMakeFiles/muelu-adapters.dir/ExplicitInstantiation/Thyra_XpetraLinearOp.cpp.o
FAILED: packages/muelu/adapters/CMakeFiles/muelu-adapters.dir/ExplicitInstantiation/Thyra_XpetraLinearOp.cpp.o 
/projects/sems/install/rhel7-x86_64/sems/v2/tpl/openmpi/1.10.7/gcc/10.1.0/base/7jgrwmo/bin/mpicxx  -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-build -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-build/packages/muelu/adapters -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/muelu/adapters/belos -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/muelu/adapters/tpetra -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/muelu/adapters/stratimikos -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/muelu/src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/muelu/src/Graph -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/muelu/src/Graph/BrickAggregation -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/muelu/src/Graph/Containers -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/muelu/src/Graph/CoupledAggregation -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/muelu/src/Graph/HybridAggregation -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/muelu/src/Graph/MatrixTransformation -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/muelu/src/Graph/PairwiseAggregation -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/muelu/src/Graph/StructuredAggregation -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/muelu/src/Graph/StructuredAggregation/coupled -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/muelu/src/Graph/StructuredAggregation/uncoupled -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/muelu/src/Graph/UncoupledAggregation -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/muelu/src/Graph/UserAggregation -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/muelu/src/Headers -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/muelu/src/Interface -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/muelu/src/Interface/FacadeClasses -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/muelu/src/Misc -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/muelu/src/MueCentral -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/muelu/src/Operators -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/muelu/src/Rebalancing -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/muelu/src/Smoothers -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/muelu/src/Transfers/BaseClass -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/muelu/src/Transfers/BlackBox -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/muelu/src/Smoothers/BlockedSmoothers -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/muelu/src/Transfers/BlockedTransfers -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/muelu/src/Transfers/Classical -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/muelu/src/Transfers/Energy-Minimization -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/muelu/src/Transfers/Energy-Minimization/Solvers -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/muelu/src/Transfers/GeneralGeometric -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/muelu/src/Transfers/Generic -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/muelu/src/Transfers/Geometric-Interpolation -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/muelu/src/Transfers/Matrix-Free -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/muelu/src/Transfers/Petrov-Galerkin-SA -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/muelu/src/Transfers/SemiCoarsen -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/muelu/src/Transfers/Smoothed-Aggregation -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/muelu/src/Transfers/User -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/muelu/src/Utils -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/muelu/src/Utils/ForwardDeclaration -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/muelu/src/../adapters/xpetra -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/muelu/src/../adapters/tpetra -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/muelu/src/Transfers/PCoarsen -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/muelu/src/../adapters/stratimikos -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-build/packages/muelu/src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-build/packages/teuchos/core/src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/teuchos/core/src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-build/packages/kokkos/core/src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/kokkos/core/src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-build/packages/kokkos -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/kokkos/core/src/../../tpls/desul/include -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/teuchos/parser/src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/teuchos/parameterlist/src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/teuchos/comm/src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/teuchos/numerics/src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/teuchos/remainder/src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-build/packages/teuchos/remainder/src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-build/packages/teuchos/kokkoscompat/src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/teuchos/kokkoscompat/src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-build/packages/teuchos/kokkoscomm/src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/teuchos/kokkoscomm/src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/xpetra/src/CrsGraph -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/xpetra/src/CrsMatrix -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/xpetra/src/BlockedCrsMatrix -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/xpetra/src/DistObject -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/xpetra/src/Export -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/xpetra/src/Headers -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/xpetra/src/Import -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/xpetra/src/Map -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/xpetra/src/BlockedMap -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/xpetra/src/MultiVector -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/xpetra/src/BlockedMultiVector -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/xpetra/src/BlockedVector -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/xpetra/src/Operator -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/xpetra/src/Platform -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/xpetra/src/RowGraph -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/xpetra/src/RowMatrix -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/xpetra/src/Utils -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/xpetra/src/Utils/ForwardDeclaration -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/xpetra/src/Vector -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-build/packages/xpetra/src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-build/packages/kokkos/containers/src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/kokkos/containers/src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/tpetra/core/compat -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-build/packages/tpetra/core/compat -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-build/packages/kokkos/algorithms/src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/kokkos/algorithms/src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-build/packages/kokkos-kernels/src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/kokkos-kernels/src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/kokkos-kernels/src/impl -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-build/packages/kokkos-kernels/src/impl -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/kokkos-kernels/src/impl/tpls -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/kokkos-kernels/src/blas -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/kokkos-kernels/src/blas/impl -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/kokkos-kernels/src/sparse -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/kokkos-kernels/src/sparse/impl -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/kokkos-kernels/src/graph -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/kokkos-kernels/src/graph/impl -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/kokkos-kernels/src/batched -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/kokkos-kernels/src/batched/dense -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/kokkos-kernels/src/batched/dense/impl -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/kokkos-kernels/src/batched/sparse -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/kokkos-kernels/src/batched/sparse/impl -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/kokkos-kernels/src/common -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/tpetra/core/src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/tpetra/core/src/kokkos_refactor -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-build/packages/tpetra/core/src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/tpetra/core/inout -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-build/packages/tpetra/core/inout -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/tpetra/core/ext -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-build/packages/tpetra/core/ext -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/xpetra/sup/Matrix -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/xpetra/sup/StridedMap -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/xpetra/sup/Utils -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-build/packages/xpetra/sup -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-build/packages/amesos2/src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/amesos2/src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/amesos2/src/KLU2/Include -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/amesos2/src/KLU2/Source -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/common/auxiliarySoftware/SuiteSparse/src/AMD/Include -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/common/auxiliarySoftware/SuiteSparse/src/COLAMD/Include -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/common/auxiliarySoftware/SuiteSparse/src/BTF/Include -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/common/auxiliarySoftware/SuiteSparse/src/UFconfig -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-build/packages/common/auxiliarySoftware/SuiteSparse/src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/common/auxiliarySoftware/SuiteSparse/src/CAMD/Include -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/common/auxiliarySoftware/SuiteSparse/src/CCOLAMD/Include -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/common/auxiliarySoftware/SuiteSparse/src/KLU/Include -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-build/packages/belos/src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/belos/src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-build/packages/belos/tpetra/src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/belos/tpetra/src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-build/packages/belos/xpetra/src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/belos/xpetra/src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/ifpack2/src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-build/packages/ifpack2/src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/zoltan2/core/src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-build/packages/zoltan2/core/src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/zoltan2/core/src/algorithms -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/zoltan2/core/src/algorithms/partition -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/zoltan2/core/src/algorithms/order -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/zoltan2/core/src/algorithms/color -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/zoltan2/core/src/algorithms/match -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/zoltan2/core/src/algorithms/map -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/zoltan2/core/src/algorithms/zoltan -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/zoltan2/core/src/environment -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/zoltan2/core/src/include -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/zoltan2/core/src/input -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/zoltan2/core/src/models -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/zoltan2/core/src/problems -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/zoltan2/core/src/TpetraCrsColorer -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/zoltan2/core/src/util -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/zoltan2/core/src/directory -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-build/packages/zoltan/src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/zoltan/src/include -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/zoltan/src/all -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/zoltan/src/coloring -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/zoltan/src/graph -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/zoltan/src/ha -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/zoltan/src/hier -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/zoltan/src/hsfc -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/zoltan/src/lb -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/zoltan/src/matrix -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/zoltan/src/order -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/zoltan/src/par -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/zoltan/src/params -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/zoltan/src/tpls -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/zoltan/src/phg -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/zoltan/src/rcb -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/zoltan/src/reftree -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/zoltan/src/simple -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/zoltan/src/timer -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/zoltan/src/Utilities/Communication -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/zoltan/src/Utilities/DDirectory -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/zoltan/src/Utilities/Timer -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/zoltan/src/Utilities/shared -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/zoltan/src/zz -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/thyra/adapters/tpetra/src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/thyra/core/src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/thyra/core/src/interfaces/operator_vector/fundamental -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/thyra/core/src/interfaces/operator_vector/extended -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/thyra/core/src/support/operator_vector/client_support -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/thyra/core/src/support/operator_vector/adapter_support -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/thyra/core/src/interfaces/operator_solve/fundamental -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/thyra/core/src/interfaces/operator_solve/extended -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/thyra/core/src/support/operator_solve/client_support -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/thyra/core/src/interfaces/nonlinear/model_evaluator/fundamental -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/thyra/core/src/support/nonlinear/model_evaluator/client_support -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/thyra/core/src/interfaces/nonlinear/solvers/fundamental -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/thyra/core/src/support/nonlinear/solvers/client_support -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-build/packages/thyra/core/src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/thyra/core/example/operator_vector -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/rtop/src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/rtop/src/interfaces -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/rtop/src/support -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/rtop/src/ops_lib -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/rtop/src/lapack -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-build/packages/rtop/src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/ifpack2/adapters/thyra -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-build/packages/ifpack2/adapters -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-build/packages/intrepid2/src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/intrepid2/src/Cell -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/intrepid2/src/Discretization/Basis -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/intrepid2/src/Discretization/FunctionSpaceTools -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/intrepid2/src/Discretization/Integration -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/intrepid2/src/Orientation -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/intrepid2/src/Projection -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/intrepid2/src/Shared -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/intrepid2/src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-build/packages/shards/src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/shards/src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-build/packages/sacado/src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/sacado/src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/sacado/src/new_design -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/sacado/src/template -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/sacado/src/parameter -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/sacado/src/mpl -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/stratimikos/adapters/amesos2/src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-build/packages/stratimikos/adapters/amesos2/src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/stratimikos/adapters/belos/src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/stratimikos/adapters/belos/src/tpetra -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-build/packages/stratimikos/adapters/belos/src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-build/packages/stratimikos/adapters/belos/src/../../../src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-build/packages/stratimikos/src -I/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/stratimikos/src -isystem /projects/sems/install/rhel7-x86_64/sems/v2/tpl/boost/1.69.0/gcc/10.1.0/base/cp2dkag/include -pedantic -Wall -Wno-long-long -Wwrite-strings -Wshadow -Woverloaded-virtual -O3 -ansi -pedantic -ftrapv -w -DBOOST_NO_HASH   -Wno-unused-local-typedefs -O3 -DNDEBUG -std=c++17 -MD -MT packages/muelu/adapters/CMakeFiles/muelu-adapters.dir/ExplicitInstantiation/Thyra_XpetraLinearOp.cpp.o -MF packages/muelu/adapters/CMakeFiles/muelu-adapters.dir/ExplicitInstantiation/Thyra_XpetraLinearOp.cpp.o.d -o packages/muelu/adapters/CMakeFiles/muelu-adapters.dir/ExplicitInstantiation/Thyra_XpetraLinearOp.cpp.o -c /ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-build/packages/muelu/adapters/ExplicitInstantiation/Thyra_XpetraLinearOp.cpp
In file included from /ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-build/packages/muelu/adapters/ExplicitInstantiation/Thyra_XpetraLinearOp.cpp:52:
/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/muelu/adapters/stratimikos/Thyra_XpetraLinearOp_def.hpp: In member function 'void Thyra::XpetraLinearOp<Scalar, LocalOrdinal, GlobalOrdinal, Node>::applyImpl(Thyra::EOpTransp, const Thyra::MultiVectorBase<Scalar>&, const Teuchos::Ptr<Thyra::MultiVectorBase<Scalar> >&, Scalar, Scalar) const':
/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/muelu/adapters/stratimikos/Thyra_XpetraLinearOp_def.hpp:162:15: error: 'ThyraUtils' is not a member of 'Xpetra'
  162 |       Xpetra::ThyraUtils<Scalar,LocalOrdinal,GlobalOrdinal,Node>::toXpetra(rcpFromRef(X_in), comm);
      |               ^~~~~~~~~~
/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/muelu/adapters/stratimikos/Thyra_XpetraLinearOp_def.hpp:162:32: error: expected primary-expression before ',' token
  162 |       Xpetra::ThyraUtils<Scalar,LocalOrdinal,GlobalOrdinal,Node>::toXpetra(rcpFromRef(X_in), comm);
      |                                ^
/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/muelu/adapters/stratimikos/Thyra_XpetraLinearOp_def.hpp:164:15: error: 'ThyraUtils' is not a member of 'Xpetra'
  164 |       Xpetra::ThyraUtils<Scalar,LocalOrdinal,GlobalOrdinal,Node>::toXpetra(rcpFromPtr(Y_inout), comm);
      |               ^~~~~~~~~~
/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/muelu/adapters/stratimikos/Thyra_XpetraLinearOp_def.hpp:164:32: error: expected primary-expression before ',' token
  164 |       Xpetra::ThyraUtils<Scalar,LocalOrdinal,GlobalOrdinal,Node>::toXpetra(rcpFromPtr(Y_inout), comm);
      |                                ^
/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/muelu/adapters/stratimikos/Thyra_XpetraLinearOp_def.hpp:177:23: error: 'ProductMultiVectorBase' is not a member of 'Thyra'; did you mean 'MultiVectorBase'?
  177 |   Teuchos::Ptr<Thyra::ProductMultiVectorBase<Scalar> > prodY_inout =
      |                       ^~~~~~~~~~~~~~~~~~~~~~
      |                       MultiVectorBase
/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/muelu/adapters/stratimikos/Thyra_XpetraLinearOp_def.hpp:177:52: error: template argument 1 is invalid
  177 |   Teuchos::Ptr<Thyra::ProductMultiVectorBase<Scalar> > prodY_inout =
      |                                                    ^
/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/muelu/adapters/stratimikos/Thyra_XpetraLinearOp_def.hpp:177:54: error: expected unqualified-id before '>' token
  177 |   Teuchos::Ptr<Thyra::ProductMultiVectorBase<Scalar> > prodY_inout =
      |                                                      ^
/ascldap/users/MrHyDE/nightly/Trilinos/Trilinos-source/packages/muelu/adapters/stratimikos/Thyra_XpetraLinearOp_def.hpp:179:6: error: 'prodY_inout' was not declared in this scope; did you mean 'tY_inout'?
  179 |   if(prodY_inout != Teuchos::null) {
      |      ^~~~~~~~~~~
      |      tY_inout
[5495/5962] Building CXX object packages/muelu/src/CMakeFiles/muelu.dir/Utils/ExplicitInstantiation/ETI_MueLu_ClassicalMapFactory.cpp.o
ninja: build stopped: subcommand failed.
bartlettroscoe commented 1 year ago

Okay, I will give this another try to reproduce on my end (starting with as close to your configure script as I can). I am on travel this week so it may be next week before I get to this.

Is this a show-stopper or do you have a workaround for now?

GrahamBenHarper commented 1 year ago

It's not blocking anything crucial for the time being :)

github-actions[bot] commented 8 months ago

This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity. If you would like to keep this issue open please add a comment and/or remove the MARKED_FOR_CLOSURE label. If this issue should be kept open even with no activity beyond the time limits you can add the label DO_NOT_AUTOCLOSE. If it is ok for this issue to be closed, feel free to go ahead and close it. Please do not add any comments or change any labels or otherwise touch this issue unless your intention is to reset the inactivity counter for an additional year.

github-actions[bot] commented 7 months ago

This issue was closed due to inactivity for 395 days.