trilinos / Trilinos

Primary repository for the Trilinos Project
https://trilinos.org/
Other
1.19k stars 565 forks source link

Teuchos::size overload problem #11591

Closed VictorEijkhout closed 5 months ago

VictorEijkhout commented 1 year ago
[ 16%] Building CXX object packages/teuchos/remainder/src/CMakeFiles/teuchosremainder.dir/Teuchos_StringToIntMap.cpp.o
cd /work2/00434/eijkhout/trilinos/build-13-4-1-clx-intel-impi/packages/teuchos/remainder/src && /scratch1/projects/compilers/intel20u1/compilers_and_libraries_2020.1.217/linux/mpi/intel64/bin/mpic
xx -DTEUCHOS_LIB_EXPORTS_MODE -Dteuchosremainder_EXPORTS -I/work2/00434/eijkhout/trilinos/build-13-4-1-clx-intel-impi -I/work2/00434/eijkhout/trilinos/trilinos-13-4-1/packages/teuchos/remainder/sr
c -I/work2/00434/eijkhout/trilinos/build-13-4-1-clx-intel-impi/packages/teuchos/remainder/src -I/work2/00434/eijkhout/trilinos/build-13-4-1-clx-intel-impi/packages/teuchos/core/src -I/work2/00434/
eijkhout/trilinos/trilinos-13-4-1/packages/teuchos/core/src -I/work2/00434/eijkhout/trilinos/build-13-4-1-clx-intel-impi/packages/kokkos/core/src -I/work2/00434/eijkhout/trilinos/trilinos-13-4-1/p
ackages/kokkos/core/src -I/work2/00434/eijkhout/trilinos/build-13-4-1-clx-intel-impi/packages/kokkos -O2 -mkl -DMPICH_SKIP_MPICXX   -O3 -DNDEBUG -fPIC -std=c++17 -MD -MT packages/teuchos/remainder
/src/CMakeFiles/teuchosremainder.dir/Teuchos_StringToIntMap.cpp.o -MF CMakeFiles/teuchosremainder.dir/Teuchos_StringToIntMap.cpp.o.d -o CMakeFiles/teuchosremainder.dir/Teuchos_StringToIntMap.cpp.o
 -c /work2/00434/eijkhout/trilinos/trilinos-13-4-1/packages/teuchos/remainder/src/Teuchos_StringToIntMap.cpp
/work2/00434/eijkhout/trilinos/trilinos-13-4-1/packages/teuchos/parser/src/Teuchos_make_lalr1_parser.cpp(50): error: more than one instance of overloaded function "Teuchos::size" matches the argument list:
            function template "auto std::size(const _Container &)->decltype((<expression>))"
            function template "int Teuchos::size(const std::vector<T, std::allocator<T>> &)"
            argument types are: (const Teuchos::Grammar::Productions)
    for (int i = 0; i < size(g.productions); ++i) {
                        ^
/work2/00434/eijkhout/trilinos/trilinos-13-4-1/packages/teuchos/parser/src/Teuchos_stack.hpp(9): note: this candidate was rejected because at least one template argument could not be deduced
  int size(std::stack<T> const& s) { return static_cast<int>(s.size()); }
      ^

Intel 19 compiler.

jhux2 commented 1 year ago

@trilinos/teuchos

VictorEijkhout commented 1 year ago

I'd appreciate a resolution to this. While I can compile the latest repo pull, you have changed cmake discovery, so I can not build dealii with that.

(I have suggested before that you add dealii to your set of regression tests. It has found problems in your setup any number of times. But that's another matter.)

bartlettroscoe commented 1 year ago

This is a Trilinos build issue, not a customer build issue. Why are we not seeing this in any automated Trilinos builds? Are there no automated builds of Trilinos using Intel 19?

@sebrowne

sebrowne commented 1 year ago

That is correct. Trilinos current only has automated builds/testiong against the compilers/MPIs listed here: https://github.com/trilinos/Trilinos/wiki/Pull-Request-Testing-Interface

I will note that although that page does not include the Intel compilers, we are currently working on restoring a missing build to that page that uses Intel-2021.3.0/OpenMPI-4.0.5

bartlettroscoe commented 1 year ago

@VictorEijkhout, as you can reproduce this and we can't, can you submit a PR with a commit that fixes the problem?

VictorEijkhout commented 1 year ago

Sorry, that's not going to happen. I've never dug into your source code so I wouldn't know where to start.

I'll next explore gcc & Intel 1api.

sebrowne commented 1 year ago

@VictorEijkhout FYI, we still use the "classic" compilers from Intel, so NOT the icx/icpx/ifx compilers from OneAPI. We use icc/icpc/ifort currently with the Intel 2021.3.0 build that I'm working on. Just in case that helps/matters.

bartlettroscoe commented 1 year ago

@VictorEijkhout, apparently there is an official Trilinos compiler support policy documented at:

which seems to be consistent with what was requested above.

Thanks for reporting issues like this. This helps us get a head start once we get to porting work once we get access to build configurations for these compilers. And in the meantime, it lets other users know this is an issue so they don't need to report it as well.

github-actions[bot] commented 6 months ago

This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity. If you would like to keep this issue open please add a comment and/or remove the MARKED_FOR_CLOSURE label. If this issue should be kept open even with no activity beyond the time limits you can add the label DO_NOT_AUTOCLOSE. If it is ok for this issue to be closed, feel free to go ahead and close it. Please do not add any comments or change any labels or otherwise touch this issue unless your intention is to reset the inactivity counter for an additional year.

github-actions[bot] commented 5 months ago

This issue was closed due to inactivity for 395 days.