Closed jhux2 closed 1 year ago
Automatic mention of the @trilinos/ifpack2 team
@jennloe I'm not able to reproduce with SC=complex (with either Serial or OpenMP node type). Could you please post a minimal module list and cmake configure line?
@jennloe the DatabaseSchwarz
issues are definitely from #11517. I'm working on reproducing them, but please let me know if you can share a configure script.
There are also Chebyshev errors. My best guess is that this is caused by other changes on @jennloe's branch.
Oh, is it possible that this is building with complex<float>
enabled?
Yes, I am building with complex<float>
enabled. I have not touched anything in ifpack2, so I don't think the issue is from any changes I've made. The GPU errors were directly from building Trilinos develop, without my changes. My config is as follows:
-D TPL_ENABLE_MPI=ON \
-D Trilinos_ENABLE_Belos:BOOL=ON \
-D Trilinos_ENABLE_Teuchos:BOOL=ON \
-D Trilinos_ENABLE_Epetra:BOOL=ON \
-D Trilinos_ENABLE_Ifpack:BOOL=ON \
-D Trilinos_ENABLE_EpetraExt:BOOL=ON \
-D Trilinos_ENABLE_Triutils:BOOL=ON \
-D Trilinos_ENABLE_Tpetra:BOOL=ON \
-D Trilinos_ENABLE_Xpetra:BOOL=ON \
-D Trilinos_ENABLE_Ifpack2:BOOL=ON \
-D Trilinos_ENABLE_Thyra:BOOL=ON \
-D Trilinos_ENABLE_Stratimikos:BOOL=ON \
-D Trilinos_ENABLE_ALL_OPTIONAL_PACKAGES:BOOL=OFF \
-D Teuchos_ENABLE_COMPLEX:BOOL=ON \
-D Trilinos_ENABLE_COMPLEX:BOOL=ON \
-D Trilinos_ENABLE_OpenMP:BOOL=ON \
-D Trilinos_ENABLE_EXAMPLES:BOOL=ON \
-D Trilinos_ENABLE_TESTS:BOOL=ON \
-D KokkosKernels_ENABLE_TPL_BLAS:BOOL=ON \
-D Trilinos_ENABLE_FLOAT:BOOL=ON \
-D Teuchos_ENABLE_FLOAT:BOOL=ON \
-D HAVE_TEUCHOS_BLASFLOAT:BOOL=ON \
-D KokkosKernels_INST_FLOAT:BOOL=ON \
-D TPL_ENABLE_BLAS:STRING=ON \
-D TPL_BLAS_LIBRARIES:STRING=${BLAS_LIBRARIES} \
-D TPL_ENABLE_LAPACK:STRING=ON \
-D TPL_LAPACK_LIBRARIES:STRING=${LAPACK_LIBRARIES} \
complex
Yes, I am building with
complex<float>
enabled. I have not touched anything in ifpack2, so I don't think the issue is from any changes I've made. The GPU errors were directly from building Trilinos develop, without my changes. My config is as follows:
Ah, this explains how we didn't see this. PR testing enablescomplex<double>
-- is this sufficient for your needs? @csiefer2's comment makes me wonder if this is just the tip of the iceberg.
We test complex<double>
I think? I don't think anyone uses complex<float>
, and there is no testing for it.
I guess my question would be whether this still shows up with float on but complex<float>
off?
I guess my question would be whether this still shows up with float on but
complex<float>
off?
Good question -- I don't believe PR testing covers float
, either.
We added a nightly build for float
on lightsaber for that reason.
@cgcgcg Ah, that's right, thanks. @jennloe that build looks clean, and covers these packages:
KokkosCore KokkosContainers KokkosAlgorithms KokkosSimd Kokkos TeuchosCore TeuchosParser TeuchosParameterList TeuchosComm TeuchosNumerics TeuchosRemainder TeuchosKokkosCompat TeuchosKokkosComm Teuchos KokkosKernels RTOp Sacado Zoltan Shards Triutils TpetraTSQR TpetraCore Tpetra TrilinosSS ThyraCore ThyraTpetraAdapters Thyra Xpetra Galeri Pamgen Zoltan2Core Belos ShyLU_NodeHTS ShyLU_NodeTacho ShyLU_Node Amesos2 Anasazi Ifpack2 Stratimikos Teko Intrepid2 MueLu
Okay, that sounds fine. We can close the issue, then.
Bug Report
Reported by @jennloe.
@trilinos/ifpack2 @GrahamBenHarper
GPU compile error
``` packages/ifpack2/src/CMakeFiles/ifpack2.dir/Ifpack2_Details_Chebyshev_OpenMP.cpp.o -c /ascldap/users/jloe/Software/AscicGPUTrilinosDev/packages/ifpack2/src/Ifpack2_Details_Chebyshev_OpenMP.cpp /ascldap/users/jloe/TrilinosDev/Trilinos/packages/ifpack2/src/Ifpack2_Details_Chebyshev_def.hpp(1346): error: no operator "/" matches these operands operand types are: double / std::complexCPU compile error
``` packages/ifpack2/src/CMakeFiles/ifpack2.dir/Ifpack2_DatabaseSchwarz_OpenMP.cpp.o -c /ascldap/users/jloe/TrilinosInstalls/DenseAbstractTest/packages/ifpack2/src/Ifpack2_DatabaseSchwarz_OpenMP.cpp from /ascldap/users/jloe/TrilinosInstalls/DenseAbstractTest/packages/ifpack2/src/Ifpack2_DatabaseSchwarz_OpenMP.cpp:44: /net/sherlock.sandia.gov/storage/fast/projects/sems/install/rhel7-x86_64/sems/compiler/gcc/8.3.0/base/include/c++/8.3.0/complex:395:5: note: candidate: ‘template