search

trilinos / Trilinos

Primary repository for the Trilinos Project
https://trilinos.org/
Other
1.2k stars 563 forks source link

Intrepid2: Valgrind warning #11847

Closed cgcgcg closed 2 weeks ago

cgcgcg commented 1 year ago

@trilinos/intrepid2 @CamelliaDPG

Bug Report

Our nightly valgrind runs flagged something in StructuredIntegration: https://testing.sandia.gov/cdash/viewDynamicAnalysisFile.php?id=517238

CamelliaDPG commented 1 year ago

@cgcgcg Thanks for the report. That's interesting; it looks like it's an issue with the (implicit) Data copy constructor. Not too sure beyond that at the moment, but I'll investigate!

github-actions[bot] commented 5 months ago

This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity. If you would like to keep this issue open please add a comment and/or remove the MARKED_FOR_CLOSURE label. If this issue should be kept open even with no activity beyond the time limits you can add the label DO_NOT_AUTOCLOSE. If it is ok for this issue to be closed, feel free to go ahead and close it. Please do not add any comments or change any labels or otherwise touch this issue unless your intention is to reset the inactivity counter for an additional year.

github-actions[bot] commented 4 months ago

This issue was closed due to inactivity for 395 days.

cgcgcg commented 3 months ago

This is still an issue: https://sems-cdash-son.sandia.gov/cdash/viewDynamicAnalysis.php?buildid=88102

CamelliaDPG commented 1 month ago

@cgcgcg Sorry for neglecting this. Looking at the log you linked, at the top it says:

==74601== Warning: client switching stacks?  SP change: 0x1ffee84e20 --> 0x1ffeadbf40
==74601==          to suppress, use: --max-stackframe=3837664 or greater

Would it be possible to change the invocation of valgrind to include --max-stackframe=3837664 (or preferably greater)? I think these may be spurious errors stemming from us using more memory than valgrind is expecting.

mperego commented 2 weeks ago

@cgcgcg who's taking care of the valgrind builds? Is it possible to make the change requested by @CamelliaDPG ?

ccober6 commented 2 weeks ago

@sebrowne can you help with this valgrind change?

cgcgcg commented 2 weeks ago

Those builds are owned by the MueLu team. I ended up disabling Intrepid2 because of issues with link times.

mperego commented 2 weeks ago

OK. Can we close this issue?

cgcgcg commented 2 weeks ago

Sounds good to me.