search

trilinos / Trilinos

Primary repository for the Trilinos Project
https://trilinos.org/
Other
1.2k stars 563 forks source link

Tpetra: Missing header file in installation #12127

Open esys-escript opened 1 year ago

esys-escript commented 1 year ago

@csiefer2

In certain circumstances it is possible to install Trilinos using the 14-4-0 tarball such that Kokkos_DefaultNode.hpp is installed but KokkosCompat_DefaultNode.hpp is not. This causes a compilation error in some third party software as Kokkos_DefaultNode.hpp explicitly includes KokkosCompat_DefaultNode.hpp.

To reproduce the bug, execute the following commands in a docker container running debian:sid.

apt update apt -y upgrade apt -y install cmake gfortran g++ libblas-dev liblapack-dev wget wget https://github.com/trilinos/Trilinos/archive/refs/tags/trilinos-release-14-4-0.tar.gz tar xf trilinos-release-14-4-0.tar.gz mkdir trilinos_build ; cd trilinos_build cmake -DCMAKE_INSTALL_PREFIX='/usr/local/trilinos' -DTrilinos_ENABLE_CXX11:BOOL=ON -DBUILD_SHARED_LIBS:BOOL=ON -DTPL_ENABLE_BLAS:BOOL=ON -DTrilinos_ENABLE_Amesos:BOOL=ON -DTrilinos_ENABLE_Amesos2:BOOL=ON -DTrilinos_ENABLE_AztecOO:BOOL=ON -DTrilinos_ENABLE_Belos:BOOL=ON -DTrilinos_ENABLE_Ifpack:BOOL=ON -DTrilinos_ENABLE_Ifpack2:BOOL=ON -DTrilinos_ENABLE_Kokkos:BOOL=ON -DTrilinos_ENABLE_Komplex:BOOL=ON -DTrilinos_ENABLE_ML:BOOL=ON -DTrilinos_ENABLE_MueLu:BOOL=ON -DTrilinos_ENABLE_Teuchos:BOOL=ON -DTrilinos_ENABLE_Tpetra:BOOL=ON -DTrilinos_ENABLE_Epetra:BOOL=ON -DTrilinos_ENABLE_EpetraExt:BOOL=ON -DTrilinos_ENABLE_ALL_OPTIONAL_PACKAGES:BOOL=OFF -DKokkos_ENABLE_AGGRESSIVE_VECTORIZATION:BOOL=ON -DTpetra_INST_COMPLEX_DOUBLE:BOOL=ON -DTrilinos_ENABLE_COMPLEX_DOUBLE:BOOL=ON -DTeuchos_ENABLE_COMPLEX:BOOL=ON -DTpetra_INST_INT_INT:BOOL=ON -DTpetra_ENABLE_DEPRECATED_CODE:BOOL=ON -DTrilinos_ENABLE_OpenMP:BOOL=ON -DTPL_ENABLE_MPI:BOOL=OFF -DTrilinos_ENABLE_EXPLICIT_INSTANTIATION:BOOL=ON -DKokkos_ENABLE_COMPILER_WARNINGS:BOOL=ON -DAmesos2_ENABLE_Basker:BOOL=ON -DTpetra_INST_SERIAL:BOOL=ON -DTrilinos_ENABLE_TESTS:BOOL=OFF /Trilinos-trilinos-release-14-4-0 make -j8 make install ls /usr/local/trilinos/include/Kokkos_DefaultNode.hpp ls /usr/local/trilinos/include/KokkosCompat_DefaultNode.hpp

csiefer2 commented 1 year ago

@esys-escript Our installation testing is... minimal at best, so thanks for reporting this. Please look over the PR in #12131 and see if that fixes your issue.

esys-escript commented 1 year ago

If I clone the develop branch and run through the installation process above, the file KokkosCompat_DefaultNode.hpp is not installed.

This issue is not urgent for me. I've fallen back on an older version for the moment.

csiefer2 commented 1 year ago

@esys-escript Yes, but that header shouldn't be needed any more. #12131 should have fixed that

github-actions[bot] commented 1 month ago

This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity. If you would like to keep this issue open please add a comment and/or remove the MARKED_FOR_CLOSURE label. If this issue should be kept open even with no activity beyond the time limits you can add the label DO_NOT_AUTOCLOSE. If it is ok for this issue to be closed, feel free to go ahead and close it. Please do not add any comments or change any labels or otherwise touch this issue unless your intention is to reset the inactivity counter for an additional year.