Amesos: define/cast errors

[andreili]

Bug Report

@srajama1

Description

All of this bugs a valid for version 14.4.0 and git hash 5aaae1ada6fe1ce777e671a0ff84fdc4f0779406.

On Amesos CSparse module I see two issues (detected on linking for Xyce simulator):

• Invalid "ifdef/include" order;
• Invalid cast for malloc.

About order - into Amesos_CSparse.h/.cpp we have "#ifdef HAVE_AMESOS_CSPARSE" before include configure file. And this causes to ignore all sources on this module: https://github.com/trilinos/Trilinos/blob/master/packages/amesos/src/Amesos_CSparse.h#L31 https://github.com/trilinos/Trilinos/blob/master/packages/amesos/src/Amesos_CSparse.cpp#L29

About cast - after fix a configuration define, I see a cast error (invalid cast from "ptrdiff_t" to "unsigned long int") on this two lines: https://github.com/trilinos/Trilinos/blob/master/packages/amesos/src/Amesos_CSparse.cpp#L137 https://github.com/trilinos/Trilinos/blob/master/packages/amesos/src/Amesos_CSparse.cpp#L138

[jhux2]

@trilinos/amesos

[github-actions[bot]]

This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity. If you would like to keep this issue open please add a comment and/or remove the MARKED_FOR_CLOSURE label. If this issue should be kept open even with no activity beyond the time limits you can add the label DO_NOT_AUTOCLOSE. If it is ok for this issue to be closed, feel free to go ahead and close it. Please do not add any comments or change any labels or otherwise touch this issue unless your intention is to reset the inactivity counter for an additional year.