trilinos / Trilinos

Primary repository for the Trilinos Project
https://trilinos.org/
Other
1.22k stars 568 forks source link

kokkos-kernels: gemm fails on host Views with rocBLAS enabled #13470

Open japlews opened 1 month ago

japlews commented 1 month ago

Bug Report

We are seeing this in Sierra builds. Compile with HIP and rocBLAS, and the below code fails to build. It attempts to run on the device, despite that execution_space is Kokkos::Serial. Here's a MRE:

TEST(KokkosGEMMBug, hipEnabledGemmHostViewFails) {
    using ExecSpace = Kokkos::DefaultHostExecutionSpace;
    const double alpha = 1.0;
    const double beta = 0.0;
    Kokkos::View<double*, ExecSpace> a, b, c;
    KokkosBlas::gemm("N", "N", alpha, b, c, beta, a);
}

It looks like there is some compile-time checking missing in KokkosKernels Level 3 BLAS...

japlews commented 1 month ago

@lucbv can you confirm whether this issue is still in Kokkos Kernels itself?

csiefer2 commented 1 month ago

@cwpearson

lucbv commented 1 month ago

I am having a look at this