trilinos / Trilinos

Primary repository for the Trilinos Project
https://trilinos.org/
Other
1.22k stars 570 forks source link

IOSS: Fix single-rank file open integer size #13518

Closed gsjaardema closed 1 month ago

gsjaardema commented 1 month ago

@trilinos/seacas @tcfisher

Motivation

The line decomposition option opens an intermediate file to do the line decomposition modifications. The integer API size of this file read/write was not matching the integer API size of the routine that called the decomposition which was casuing a field size mismatch for some operations.

Fixed so the integer size matches which should solve the SPARC issue.

Related Issues

COMPSIMHD-18566

Stakeholder Feedback

Testing

trilinos-autotester commented 1 month ago

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request.

trilinos-autotester commented 1 month ago

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: PR_gcc-openmpi-openmp

  • Build Num: 607
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-gnu-8.5.0-openmpi-4.1.6-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: seacas;AT: AUTOMERGE;client: SPARC;PA: Data Services
PULLREQUESTNUM 13518
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA f6fb1918e72113ae7e9926771ee855ad0918782d
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 8729aaee82e7464ea6824d8d4a225e195ffd40c2

Build Information

Test Name: PR_gcc

  • Build Num: 657
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-gnu-8.5.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: seacas;AT: AUTOMERGE;client: SPARC;PA: Data Services
PULLREQUESTNUM 13518
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA f6fb1918e72113ae7e9926771ee855ad0918782d
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 8729aaee82e7464ea6824d8d4a225e195ffd40c2

Build Information

Test Name: PR_gcc-openmpi_debug

  • Build Num: 658
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-gnu-8.5.0-openmpi-4.1.6-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: seacas;AT: AUTOMERGE;client: SPARC;PA: Data Services
PULLREQUESTNUM 13518
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA f6fb1918e72113ae7e9926771ee855ad0918782d
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 8729aaee82e7464ea6824d8d4a225e195ffd40c2

Build Information

Test Name: PR_clang

  • Build Num: 656
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-clang-11.0.1-openmpi-4.0.5-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: seacas;AT: AUTOMERGE;client: SPARC;PA: Data Services
PULLREQUESTNUM 13518
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA f6fb1918e72113ae7e9926771ee855ad0918782d
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 8729aaee82e7464ea6824d8d4a225e195ffd40c2

Build Information

Test Name: Trilinos_PR_python3

  • Build Num: 4615
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
BLOCKING_BUILD false
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_aue-gnu-12.1.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS pkg: seacas;AT: AUTOMERGE;client: SPARC;PA: Data Services
PULLREQUESTNUM 13518
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA f6fb1918e72113ae7e9926771ee855ad0918782d
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 8729aaee82e7464ea6824d8d4a225e195ffd40c2

Build Information

Test Name: PR_cuda

  • Build Num: 655
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: seacas;AT: AUTOMERGE;client: SPARC;PA: Data Services
PULLREQUESTNUM 13518
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8-gpu
TRILINOS_SOURCE_REPO https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA f6fb1918e72113ae7e9926771ee855ad0918782d
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 8729aaee82e7464ea6824d8d4a225e195ffd40c2

Build Information

Test Name: PR_intel

  • Build Num: 576
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-intel-2021.3-sems-openmpi-4.1.6_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: seacas;AT: AUTOMERGE;client: SPARC;PA: Data Services
PULLREQUESTNUM 13518
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA f6fb1918e72113ae7e9926771ee855ad0918782d
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 8729aaee82e7464ea6824d8d4a225e195ffd40c2

Build Information

Test Name: PR_cuda-uvm

  • Build Num: 655
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_uvm_deprecated-on_no-package-enables
PR_LABELS pkg: seacas;AT: AUTOMERGE;client: SPARC;PA: Data Services
PULLREQUESTNUM 13518
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA f6fb1918e72113ae7e9926771ee855ad0918782d
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 8729aaee82e7464ea6824d8d4a225e195ffd40c2

Using Repos:

Repo: TRILINOS (gsjaardema/Trilinos)
  • Branch: IOSS-fix-line-decomp-32-bit-file
  • SHA: f6fb1918e72113ae7e9926771ee855ad0918782d
  • Mode: TEST_REPO
Pull Request Author: gsjaardema
trilinos-autotester commented 1 month ago

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: PR_gcc-openmpi-openmp

  • Build Num: 607
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-gnu-8.5.0-openmpi-4.1.6-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: seacas;AT: AUTOMERGE;client: SPARC;PA: Data Services
PULLREQUESTNUM 13518
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA f6fb1918e72113ae7e9926771ee855ad0918782d
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 8729aaee82e7464ea6824d8d4a225e195ffd40c2

Build Information

Test Name: PR_gcc

  • Build Num: 657
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-gnu-8.5.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: seacas;AT: AUTOMERGE;client: SPARC;PA: Data Services
PULLREQUESTNUM 13518
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA f6fb1918e72113ae7e9926771ee855ad0918782d
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 8729aaee82e7464ea6824d8d4a225e195ffd40c2

Build Information

Test Name: PR_gcc-openmpi_debug

  • Build Num: 658
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-gnu-8.5.0-openmpi-4.1.6-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: seacas;AT: AUTOMERGE;client: SPARC;PA: Data Services
PULLREQUESTNUM 13518
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA f6fb1918e72113ae7e9926771ee855ad0918782d
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 8729aaee82e7464ea6824d8d4a225e195ffd40c2

Build Information

Test Name: PR_clang

  • Build Num: 656
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-clang-11.0.1-openmpi-4.0.5-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: seacas;AT: AUTOMERGE;client: SPARC;PA: Data Services
PULLREQUESTNUM 13518
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA f6fb1918e72113ae7e9926771ee855ad0918782d
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 8729aaee82e7464ea6824d8d4a225e195ffd40c2

Build Information

Test Name: Trilinos_PR_python3

  • Build Num: 4615
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
BLOCKING_BUILD false
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_aue-gnu-12.1.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS pkg: seacas;AT: AUTOMERGE;client: SPARC;PA: Data Services
PULLREQUESTNUM 13518
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA f6fb1918e72113ae7e9926771ee855ad0918782d
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 8729aaee82e7464ea6824d8d4a225e195ffd40c2

Build Information

Test Name: PR_cuda

  • Build Num: 655
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: seacas;AT: AUTOMERGE;client: SPARC;PA: Data Services
PULLREQUESTNUM 13518
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8-gpu
TRILINOS_SOURCE_REPO https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA f6fb1918e72113ae7e9926771ee855ad0918782d
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 8729aaee82e7464ea6824d8d4a225e195ffd40c2

Build Information

Test Name: PR_intel

  • Build Num: 576
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-intel-2021.3-sems-openmpi-4.1.6_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: seacas;AT: AUTOMERGE;client: SPARC;PA: Data Services
PULLREQUESTNUM 13518
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA f6fb1918e72113ae7e9926771ee855ad0918782d
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 8729aaee82e7464ea6824d8d4a225e195ffd40c2

Build Information

Test Name: PR_cuda-uvm

  • Build Num: 655
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_uvm_deprecated-on_no-package-enables
PR_LABELS pkg: seacas;AT: AUTOMERGE;client: SPARC;PA: Data Services
PULLREQUESTNUM 13518
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA f6fb1918e72113ae7e9926771ee855ad0918782d
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 8729aaee82e7464ea6824d8d4a225e195ffd40c2


CDash Test Results for PR# 13518.

trilinos-autotester commented 1 month ago

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging NO REVIEWS HAVE BEEN PERFORMED ON THIS PULL REQUEST!

trilinos-autotester commented 1 month ago

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

gsjaardema commented 1 month ago

@alanw0 @tokusanya @rppawlo Can one of you give a quick look at this. Only a few lines this time...

trilinos-autotester commented 1 month ago

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ alanw0 ]!

trilinos-autotester commented 1 month ago

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

trilinos-autotester commented 1 month ago

Merge on Pull Request# 13518: IS A SUCCESS - Pull Request successfully merged