Closed cgcgcg closed 3 weeks ago
@trilinos/teuchos
Teuchos::ConstNonconstObjectContainer::count uses RCP::count() but there is no such method: https://github.com/trilinos/Trilinos/blob/e7fd307aba00df75d7aad0677d45cec45eea4251/packages/teuchos/core/src/Teuchos_ConstNonconstObjectContainer.hpp#L332-L333 What's the correct fix here?
Teuchos::ConstNonconstObjectContainer::count
RCP::count()
RCP::weak_count()
RCP::strong_count()
I would vote for deleting it. Users can just grab the RCP and query the count themselves.
@bartlettroscoe Sounds good. I'll delete the method.
@trilinos/teuchos
Bug Report
Teuchos::ConstNonconstObjectContainer::count
usesRCP::count()
but there is no such method: https://github.com/trilinos/Trilinos/blob/e7fd307aba00df75d7aad0677d45cec45eea4251/packages/teuchos/core/src/Teuchos_ConstNonconstObjectContainer.hpp#L332-L333 What's the correct fix here?RCP::weak_count()
, orRCP::strong_count()
, orTeuchos::ConstNonconstObjectContainer::count
since it's not used anywhere?