ROL: avoid using namespace directive in header.

trilinos / Trilinos

Primary repository for the Trilinos Project

https://trilinos.org/

Other

1.22k stars 570 forks source link

ROL: avoid using namespace directive in header. #13560

Open marcfehling opened 3 weeks ago

marcfehling commented 3 weeks ago

@trilinos/rol @dridzal @gregvw

A using namespace directive in a header file lead to ambiguity in user code.

In my case, I am experimenting with deal.II and ROL, which lead to name conflicts between dealii::Vector and ROL::Vector.

In a way related to #13532.

trilinos-autotester commented 3 weeks ago

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.