search

trilinos / Trilinos

Primary repository for the Trilinos Project
https://trilinos.org/
Other
1.22k stars 569 forks source link

Build fails with clang-19: no member named 'sort_option' in 'SPADDHandle<lno_row_view_t_, lno_nnz_view_t_, scalar_nnz_view_t_, ExecutionSpace, MemorySpace>' #13570

Open yurivict opened 2 weeks ago

yurivict commented 2 weeks ago 
In file included from /wrkdirs/usr/ports/science/trilinos/work/.build/packages/kokkos-kernels/graph/eti/generated_specializations_cpp/color_d1/Graph_color_d1_eti_DOUBLE_ORDINAL_INT_OFFSET_SIZE_T_LAYOUTLEFT_EXECSPACE_SERIAL_MEMSPACE_HOSTSPACE.cpp:21:
In file included from /wrkdirs/usr/ports/science/trilinos/work/Trilinos-trilinos-release-16-0-0/packages/kokkos-kernels/graph/impl/KokkosGraph_color_d1_spec.hpp:22:
In file included from /wrkdirs/usr/ports/science/trilinos/work/Trilinos-trilinos-release-16-0-0/packages/kokkos-kernels/sparse/src/KokkosKernels_Handle.hpp:21:
/wrkdirs/usr/ports/science/trilinos/work/Trilinos-trilinos-release-16-0-0/packages/kokkos-kernels/sparse/src/KokkosSparse_spadd_handle.hpp:113:44: error: no member named 'sort_option' in 'SPADDHandle<lno_row_view_t_, lno_nnz_view_t_, scalar_nnz_view_t_, ExecutionSpace, MemorySpace>'
  113 |   void set_sort_option(int option) { this->sort_option = option; }
      |                                      ~~~~  ^
/wrkdirs/usr/ports/science/trilinos/work/Trilinos-trilinos-release-16-0-0/packages/kokkos-kernels/sparse/src/KokkosSparse_spadd_handle.hpp:115:40: error: no member named 'sort_option' in 'SPADDHandle<lno_row_view_t_, lno_nnz_view_t_, scalar_nnz_view_t_, ExecutionSpace, MemorySpace>'
  115 |   int get_sort_option() { return this->sort_option; }
      |                                  ~~~~  ^

Version: 16.0.0 clang-19 FreeBSD 14.1

cgcgcg commented 2 weeks ago

FYI https://github.com/kokkos/kokkos-kernels/issues/2347

yurivict commented 2 weeks ago

It seems like Trilinos has bundled the kokkos project and this bug is in the bundled kokkos.

cgcgcg commented 2 weeks ago

Looks like it's fixed on develop.

@trilinos/framework Maybe we should consider a minor release with the fix from KokkosKernels?

brian-kelley commented 2 weeks ago

@cgcgcg This fix is included in the KokkosKernels 4.5 release which will be merged very soon, so maybe there can be a Trilinos release right after that.

brian-kelley commented 2 weeks ago

Actually never mind, this fix has been patched in develop for a while: #13403