search

trilinos / Trilinos

Primary repository for the Trilinos Project
https://trilinos.org/
Other
1.22k stars 569 forks source link

TriBITS: CuSolver TPL still uses raw find_library call #13624

Open terwin opened 15 hours ago

terwin commented 15 hours ago

Bug Report

@bartlettroscoe

Description

11093 updated CUDA TPLs to use find_package(CUDATookit) rather than raw find_ commands, but cmake/TPLs/FindTPLCUSOLVER.cmake was excluded.

bartlettroscoe commented 13 hours ago

CC: @trilinos/framework, @sebrowne

@terwin, what is the underlying driver for this request? PR #11093 was in response to a specific issue with a customer code (see #10954).

terwin commented 13 hours ago

@bartlettroscoe, I encountered this while rebuilding our code (without rebuilding Trilinos) after the CUDA installation on our system was moved. The build failed due to a single hard-coded path in the Trilinos installation (in CUSOLVERConfig.cmake). Digging into the origin of that hard-coded path, I found that the cuSOLVER TPL was inconsistent with the other CUDA TPLs and traced it back to #11093. This seemed like an oversight in that PR.

bartlettroscoe commented 12 hours ago

@terwin, if you are in position to give this a try, could you try updating cmake/TPLs/FindTPLCUSOLVER.cmake to replicate the changes made in those other modules?