search

trilinos / Trilinos

Primary repository for the Trilinos Project
https://trilinos.org/
Other
1.22k stars 569 forks source link

NOX,Panzer: minor changes to logic for a new Charon solver #13625

Closed rppawlo closed 11 hours ago

rppawlo commented 15 hours ago

@trilinos/nox @trilinos/panzer

Motivation

Charon is using the nox and loca groups as building blocks for a new solver algorithm. Added a safety check for a null vector in panzer that was triggered by their use case. Also temporarily disabled a throw in nox group logic that was forcing the Jacobian update to be handled explicitly by the user. It will now do an implicit update if needed.

Related Issues

Stakeholder Feedback

Testing

Changes are to code that is covered under current unit tests.

trilinos-autotester commented 12 hours ago

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request.

trilinos-autotester commented 12 hours ago

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: PR_gcc-openmpi-openmp

  • Build Num: 819
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-gnu-8.5.0-openmpi-4.1.6-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: NOX;pkg: Panzer;AT: AUTOMERGE;PA: Nonlinear Solvers;PA: Discretizations;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 13625
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/rppawlo/Trilinos
TRILINOS_SOURCE_SHA dc24fa11e1588d4f06af62fc2c00e219328106fe
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 70822c3f3191b8abe57c9945ec830507b6f17c43

Build Information

Test Name: PR_gcc

  • Build Num: 869
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-gnu-8.5.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: NOX;pkg: Panzer;AT: AUTOMERGE;PA: Nonlinear Solvers;PA: Discretizations;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 13625
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/rppawlo/Trilinos
TRILINOS_SOURCE_SHA dc24fa11e1588d4f06af62fc2c00e219328106fe
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 70822c3f3191b8abe57c9945ec830507b6f17c43

Build Information

Test Name: PR_gcc-openmpi_debug

  • Build Num: 870
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-gnu-8.5.0-openmpi-4.1.6-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: NOX;pkg: Panzer;AT: AUTOMERGE;PA: Nonlinear Solvers;PA: Discretizations;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 13625
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/rppawlo/Trilinos
TRILINOS_SOURCE_SHA dc24fa11e1588d4f06af62fc2c00e219328106fe
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 70822c3f3191b8abe57c9945ec830507b6f17c43

Build Information

Test Name: PR_clang

  • Build Num: 868
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-clang-11.0.1-openmpi-4.0.5-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: NOX;pkg: Panzer;AT: AUTOMERGE;PA: Nonlinear Solvers;PA: Discretizations;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 13625
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/rppawlo/Trilinos
TRILINOS_SOURCE_SHA dc24fa11e1588d4f06af62fc2c00e219328106fe
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 70822c3f3191b8abe57c9945ec830507b6f17c43

Build Information

Test Name: Trilinos_PR_python3

  • Build Num: 4827
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
BLOCKING_BUILD false
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_aue-gnu-12.1.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS pkg: NOX;pkg: Panzer;AT: AUTOMERGE;PA: Nonlinear Solvers;PA: Discretizations;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 13625
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/rppawlo/Trilinos
TRILINOS_SOURCE_SHA dc24fa11e1588d4f06af62fc2c00e219328106fe
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 70822c3f3191b8abe57c9945ec830507b6f17c43

Build Information

Test Name: PR_cuda

  • Build Num: 867
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: NOX;pkg: Panzer;AT: AUTOMERGE;PA: Nonlinear Solvers;PA: Discretizations;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 13625
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8-gpu
TRILINOS_SOURCE_REPO https://github.com/rppawlo/Trilinos
TRILINOS_SOURCE_SHA dc24fa11e1588d4f06af62fc2c00e219328106fe
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 70822c3f3191b8abe57c9945ec830507b6f17c43

Build Information

Test Name: PR_intel

  • Build Num: 788
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-intel-2021.3-sems-openmpi-4.1.6_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: NOX;pkg: Panzer;AT: AUTOMERGE;PA: Nonlinear Solvers;PA: Discretizations;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 13625
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/rppawlo/Trilinos
TRILINOS_SOURCE_SHA dc24fa11e1588d4f06af62fc2c00e219328106fe
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 70822c3f3191b8abe57c9945ec830507b6f17c43

Build Information

Test Name: PR_cuda-uvm

  • Build Num: 867
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_uvm_deprecated-on_no-package-enables
PR_LABELS pkg: NOX;pkg: Panzer;AT: AUTOMERGE;PA: Nonlinear Solvers;PA: Discretizations;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 13625
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/rppawlo/Trilinos
TRILINOS_SOURCE_SHA dc24fa11e1588d4f06af62fc2c00e219328106fe
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 70822c3f3191b8abe57c9945ec830507b6f17c43

Using Repos:

Repo: TRILINOS (rppawlo/Trilinos)
  • Branch: nox-panzer-hacks-for-charon
  • SHA: dc24fa11e1588d4f06af62fc2c00e219328106fe
  • Mode: TEST_REPO
Pull Request Author: rppawlo
trilinos-autotester commented 11 hours ago

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: PR_gcc-openmpi-openmp

  • Build Num: 819
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-gnu-8.5.0-openmpi-4.1.6-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: NOX;pkg: Panzer;AT: AUTOMERGE;PA: Nonlinear Solvers;PA: Discretizations;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 13625
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/rppawlo/Trilinos
TRILINOS_SOURCE_SHA dc24fa11e1588d4f06af62fc2c00e219328106fe
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 70822c3f3191b8abe57c9945ec830507b6f17c43

Build Information

Test Name: PR_gcc

  • Build Num: 869
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-gnu-8.5.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: NOX;pkg: Panzer;AT: AUTOMERGE;PA: Nonlinear Solvers;PA: Discretizations;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 13625
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/rppawlo/Trilinos
TRILINOS_SOURCE_SHA dc24fa11e1588d4f06af62fc2c00e219328106fe
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 70822c3f3191b8abe57c9945ec830507b6f17c43

Build Information

Test Name: PR_gcc-openmpi_debug

  • Build Num: 870
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-gnu-8.5.0-openmpi-4.1.6-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: NOX;pkg: Panzer;AT: AUTOMERGE;PA: Nonlinear Solvers;PA: Discretizations;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 13625
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/rppawlo/Trilinos
TRILINOS_SOURCE_SHA dc24fa11e1588d4f06af62fc2c00e219328106fe
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 70822c3f3191b8abe57c9945ec830507b6f17c43

Build Information

Test Name: PR_clang

  • Build Num: 868
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-clang-11.0.1-openmpi-4.0.5-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: NOX;pkg: Panzer;AT: AUTOMERGE;PA: Nonlinear Solvers;PA: Discretizations;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 13625
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/rppawlo/Trilinos
TRILINOS_SOURCE_SHA dc24fa11e1588d4f06af62fc2c00e219328106fe
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 70822c3f3191b8abe57c9945ec830507b6f17c43

Build Information

Test Name: Trilinos_PR_python3

  • Build Num: 4827
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
BLOCKING_BUILD false
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_aue-gnu-12.1.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS pkg: NOX;pkg: Panzer;AT: AUTOMERGE;PA: Nonlinear Solvers;PA: Discretizations;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 13625
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/rppawlo/Trilinos
TRILINOS_SOURCE_SHA dc24fa11e1588d4f06af62fc2c00e219328106fe
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 70822c3f3191b8abe57c9945ec830507b6f17c43

Build Information

Test Name: PR_cuda

  • Build Num: 867
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: NOX;pkg: Panzer;AT: AUTOMERGE;PA: Nonlinear Solvers;PA: Discretizations;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 13625
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8-gpu
TRILINOS_SOURCE_REPO https://github.com/rppawlo/Trilinos
TRILINOS_SOURCE_SHA dc24fa11e1588d4f06af62fc2c00e219328106fe
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 70822c3f3191b8abe57c9945ec830507b6f17c43

Build Information

Test Name: PR_intel

  • Build Num: 788
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-intel-2021.3-sems-openmpi-4.1.6_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: NOX;pkg: Panzer;AT: AUTOMERGE;PA: Nonlinear Solvers;PA: Discretizations;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 13625
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/rppawlo/Trilinos
TRILINOS_SOURCE_SHA dc24fa11e1588d4f06af62fc2c00e219328106fe
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 70822c3f3191b8abe57c9945ec830507b6f17c43

Build Information

Test Name: PR_cuda-uvm

  • Build Num: 867
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_uvm_deprecated-on_no-package-enables
PR_LABELS pkg: NOX;pkg: Panzer;AT: AUTOMERGE;PA: Nonlinear Solvers;PA: Discretizations;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 13625
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/rppawlo/Trilinos
TRILINOS_SOURCE_SHA dc24fa11e1588d4f06af62fc2c00e219328106fe
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 70822c3f3191b8abe57c9945ec830507b6f17c43


CDash Test Results for PR# 13625.

trilinos-autotester commented 11 hours ago

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ etphipp ]!

trilinos-autotester commented 11 hours ago

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

trilinos-autotester commented 11 hours ago

Merge on Pull Request# 13625: IS A SUCCESS - Pull Request successfully merged