FEI has duplicate files with HYPRE

nschloe commented 8 years ago

While working on a Debian/Ubuntu package for Trilinos, I sometimes bump into the funniest issues. This here is the fact that the existing package HYPRE and Trilinos' FEI have header files with the exact same names. Specifically, the following files are already installed by HYPRE:

$ dpkg -L libhypre-dev | grep .h | grep fei
/usr/include/cfei_hypre.h
/usr/include/fei_defs.h
/usr/include/cfei-hypre.h
/usr/include/hypre_cfei.h
$

At least fei_defs.h is also present in FEI. This makes it impossible to co-install both packages on the same system.

bartlettroscoe commented 8 years ago

I forwarded this to an HYPRE developer who is on the same IDEAS project with me. While the global package name "FEI" is a little too generic for a global namespace, this is really a HYPRE defect. HYPRE needs to namespace all of its installed header files and global symbols with "hypre_".

bartlettroscoe commented 8 years ago

Improving the interoperability between HYPRE and Trilinos is in the SCOPE of the IDEAS project. Therefore, I created an issue in that system to track this there as well (but non-IDEAS members can't read those issues). A HYPRE developer said they have added an issue in their issue tracking system to get this done.

bartlettroscoe commented 8 years ago

Nico,

Can you try --without-fei with hypre?

From: Yang, Ulrike Meier [mailto:yang11@llnl.gov] Sent: Friday, December 11, 2015 6:50 PM To: Bartlett, Roscoe A. Subject: RE: [Trilinos] FEI has duplicate files with HYPRE (#18)

Hi Ross, Btw I forgot to mention that if you configure hypre without the fei, ( configure –without-fei ) it will ignore the FEI stuff in hypre , so this might work for you guys in the meantime, until we get this fixed. Thanks Ulrike

nschloe commented 8 years ago

Well, this has to go into the Debian package and then we can have those packages co-installable.

bartlettroscoe commented 8 years ago

Need to get HYPE developers involved in this discussion. Done know if Ulrike has a GitHub account.

mhoemmen commented 8 years ago

I am CC'ing @amklinv since Alicia has been reviving Trilinos / Hypre interop.

ulrikeyang commented 8 years ago

One comment on --without-fei, this will deactivate the LinSysCore interface in hypre, which people use to connect through the FEI . So if you want to use this, then --without-fei is not a good option. If you don't, your problems should go away. Regarding this LinSysCore interface: we actually don't like it and would prefer to have a better option. One of the problems with it is that it requires us to manually include any new options we add to our AMG solver, and we are really bad about this, since we generally ignore this interface. So, if there are some better future options to get hypre connected with the FEI, we (and the few customers we have who still use the FEI with hypre) would be really happy.

eric-c-cyr commented 8 years ago

Exactly what is it your customers use FEI for?

From: ulrikeyang notifications@github.com<mailto:notifications@github.com> Reply-To: trilinos/Trilinos reply@reply.github.com<mailto:reply@reply.github.com> Date: Tuesday, December 15, 2015 at 8:26 AM To: trilinos/Trilinos Trilinos@noreply.github.com<mailto:Trilinos@noreply.github.com> Subject: [EXTERNAL] Re: [Trilinos] FEI has duplicate files with HYPRE (#18)

One comment on --without-fei, this will deactivate the LinSysCore interface in hypre, which people use to connect through the FEI . So if you want to use this, then --without-fei is not a good option. If you don't, your problems should go away. Regarding this LinSysCore interface: we actually don't like it and would prefer to have a better option. One of the problems with it is that it requires us to manually include any new options we add to our AMG solver, and we are really bad about this, since we generally ignore this interface. So, if there are some better future options to get hypre connected with the FEI, we (and the few customers we have who still use the FEI with hypre) would be really happy.

Reply to this email directly or view it on GitHubhttps://github.com/trilinos/Trilinos/issues/18#issuecomment-164797841.

ulrikeyang commented 8 years ago

They use it to generate a linear system using finite elements, which is then solved by hypre. hypre actually now allows to generate finite elements also through its semi-structured interface, but not all finite element options are available. FEI has more.

From: eric-c-cyr [mailto:notifications@github.com] Sent: Tuesday, December 15, 2015 7:41 AM To: trilinos/Trilinos Trilinos@noreply.github.com Cc: Yang, Ulrike Meier yang11@llnl.gov Subject: Re: [Trilinos] FEI has duplicate files with HYPRE (#18)

Exactly what is it your customers use FEI for?

From: ulrikeyang notifications@github.com<mailto:notifications@github.com> Reply-To: trilinos/Trilinos reply@reply.github.com<mailto:reply@reply.github.com> Date: Tuesday, December 15, 2015 at 8:26 AM To: trilinos/Trilinos Trilinos@noreply.github.com<mailto:Trilinos@noreply.github.com> Subject: [EXTERNAL] Re: [Trilinos] FEI has duplicate files with HYPRE (#18)

One comment on --without-fei, this will deactivate the LinSysCore interface in hypre, which people use to connect through the FEI . So if you want to use this, then --without-fei is not a good option. If you don't, your problems should go away. Regarding this LinSysCore interface: we actually don't like it and would prefer to have a better option. One of the problems with it is that it requires us to manually include any new options we add to our AMG solver, and we are really bad about this, since we generally ignore this interface. So, if there are some better future options to get hypre connected with the FEI, we (and the few customers we have who still use the FEI with hypre) would be really happy.

Reply to this email directly or view it on GitHubhttps://github.com/trilinos/Trilinos/issues/18#issuecomment-164797841.

— Reply to this email directly or view it on GitHubhttps://github.com/trilinos/Trilinos/issues/18#issuecomment-164801862.

eric-c-cyr commented 8 years ago

From an interface perspective, does the user enter their local stiffness matrix and load vector? Then FEI puts them all together?

From: ulrikeyang notifications@github.com<mailto:notifications@github.com> Reply-To: trilinos/Trilinos reply@reply.github.com<mailto:reply@reply.github.com> Date: Tuesday, December 15, 2015 at 8:48 AM To: trilinos/Trilinos Trilinos@noreply.github.com<mailto:Trilinos@noreply.github.com> Cc: "Cyr, Eric C" eccyr@sandia.gov<mailto:eccyr@sandia.gov> Subject: [EXTERNAL] Re: [Trilinos] FEI has duplicate files with HYPRE (#18)

They use it to generate a linear system using finite elements, which is then solved by hypre. hypre actually now allows to generate finite elements also through its semi-structured interface, but not all finite element options are available. FEI has more.

From: eric-c-cyr [mailto:notifications@github.com] Sent: Tuesday, December 15, 2015 7:41 AM To: trilinos/Trilinos Trilinos@noreply.github.com<mailto:Trilinos@noreply.github.com> Cc: Yang, Ulrike Meier yang11@llnl.gov<mailto:yang11@llnl.gov> Subject: Re: [Trilinos] FEI has duplicate files with HYPRE (#18)

Exactly what is it your customers use FEI for?

From: ulrikeyang notifications@github.com<mailto:notifications@github.commailto:notifications@github.com> Reply-To: trilinos/Trilinos reply@reply.github.com<mailto:reply@reply.github.commailto:reply@reply.github.com> Date: Tuesday, December 15, 2015 at 8:26 AM To: trilinos/Trilinos Trilinos@noreply.github.com<mailto:Trilinos@noreply.github.commailto:Trilinos@noreply.github.com> Subject: [EXTERNAL] Re: [Trilinos] FEI has duplicate files with HYPRE (#18)

One comment on --without-fei, this will deactivate the LinSysCore interface in hypre, which people use to connect through the FEI . So if you want to use this, then --without-fei is not a good option. If you don't, your problems should go away. Regarding this LinSysCore interface: we actually don't like it and would prefer to have a better option. One of the problems with it is that it requires us to manually include any new options we add to our AMG solver, and we are really bad about this, since we generally ignore this interface. So, if there are some better future options to get hypre connected with the FEI, we (and the few customers we have who still use the FEI with hypre) would be really happy.

Reply to this email directly or view it on GitHubhttps://github.com/trilinos/Trilinos/issues/18#issuecomment-164797841.

Reply to this email directly or view it on GitHubhttps://github.com/trilinos/Trilinos/issues/18#issuecomment-164801862.

Reply to this email directly or view it on GitHubhttps://github.com/trilinos/Trilinos/issues/18#issuecomment-164804380.

github-actions[bot] commented 3 years ago

This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity. If you would like to keep this issue open please add a comment and remove the MARKED_FOR_CLOSURE label. If this issue should be kept open even with no activity beyond the time limits you can add the label DO_NOT_AUTOCLOSE.

github-actions[bot] commented 3 years ago

This issue was closed due to inactivity for 395 days.

trilinos / Trilinos

FEI has duplicate files with HYPRE #18