search

trilinos / Trilinos

Primary repository for the Trilinos Project
https://trilinos.org/
Other
1.2k stars 564 forks source link

Zoltan2 test zoltanCompare may fail with Tpetra_INST_INT_INT=OFF #3286

Closed kddevin closed 2 years ago

kddevin commented 6 years ago

@trilinos/zoltan2

Expectations

Current Behavior

Zoltan2 test zoltanCompare may fail with Tpetra_INST_INT__INT=OFF due to differences in the way 64-bit are represented in the test’s interface to Zoltan and Zoltan2’s interface to Zoltan. Failing component tests are PHG. The different representations of 64-bit ids lead to different hash values and different visit orders and, thus, different partitions in the test. We will need to fix the test to use the same representation as the Zoltan2 interface.

Motivation and Context

Definition of Done

Possible Solution

Steps to Reproduce

I saw this failure on mac with Tpetra_INST_INT__INT=OFF

Your Environment

Related Issues

Additional Information

mhoemmen commented 6 years ago

@kddevin Thanks for pointing this out! I didn't see this issue in the pull request tests -- does this require a special TPL, or is it Mac-specific?

kddevin commented 6 years ago

No special TPLs needed. I saw diffs on my mac; I did not try linux. PR tests don't use Tpetra_INST_INT_INT=OFF, right? So they would be OK.

mhoemmen commented 6 years ago

@kddevin I'm just not sure what settings I would need in order to run this test.

kddevin commented 6 years ago

@mhoemmen You don't need to worry about it. As long as Zoltan2 isn't getting in your way with your other projects, fixing this issue is not a high priority. I'll get to it in due time. Thanks.

mhoemmen commented 6 years ago

Thanks @kddevin !

github-actions[bot] commented 3 years ago

This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity. If you would like to keep this issue open please add a comment and/or remove the MARKED_FOR_CLOSURE label. If this issue should be kept open even with no activity beyond the time limits you can add the label DO_NOT_AUTOCLOSE. If it is ok for this issue to be closed, feel free to go ahead and close it. Please do not add any comments or change any labels or otherwise touch this issue unless your intention is to reset the inactivity counter for an additional year.

mhoemmen commented 3 years ago

Is this fixed?

github-actions[bot] commented 2 years ago

This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity. If you would like to keep this issue open please add a comment and/or remove the MARKED_FOR_CLOSURE label. If this issue should be kept open even with no activity beyond the time limits you can add the label DO_NOT_AUTOCLOSE. If it is ok for this issue to be closed, feel free to go ahead and close it. Please do not add any comments or change any labels or otherwise touch this issue unless your intention is to reset the inactivity counter for an additional year.

github-actions[bot] commented 2 years ago

This issue was closed due to inactivity for 395 days.