search

trilinos / Trilinos

Primary repository for the Trilinos Project
https://trilinos.org/
Other
1.19k stars 565 forks source link

Amesos2: Improve handling of refactor options #7216

Closed MicheldeMessieres closed 2 years ago

MicheldeMessieres commented 4 years ago

Enhancement

@trilinos/amesos2

Amesos2 solvers will test a refactor option (--refactor) which modifies the matrix.

This is working for the current test matrices but the modification is too severe for large matrices and they will no longer be positive definite. Code applied is: for( size_t i = 0; i < l_fst_row_nnz; ++i ){ values[i] = values[i] * values[i]; } It would be preferable that any valid matrix can be replaced for the test matrix and still run refactor. The Cholmod solver is one case at least which has issues.

MicheldeMessieres commented 3 years ago

Also SuperLUDist is failing refactor.

github-actions[bot] commented 2 years ago

This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity. If you would like to keep this issue open please add a comment and/or remove the MARKED_FOR_CLOSURE label. If this issue should be kept open even with no activity beyond the time limits you can add the label DO_NOT_AUTOCLOSE. If it is ok for this issue to be closed, feel free to go ahead and close it. Please do not add any comments or change any labels or otherwise touch this issue unless your intention is to reset the inactivity counter for an additional year.

github-actions[bot] commented 2 years ago

This issue was closed due to inactivity for 395 days.