search

trilinos / Trilinos

Primary repository for the Trilinos Project
https://trilinos.org/
Other
1.2k stars 563 forks source link

ShyLU: Unit tests appear to depend on Gtest (without depending on it) #8982

Closed jjellio closed 3 years ago

jjellio commented 3 years ago

Bug Report

@trilinos/shylu

Description

I'm seeing a build failure with ATDMDevSettings + EMPIRE's cmake options file. (EMPIRE disables Gtest)

21835 /tmp/coe0201/spack-stage/spack-stage-atdm-trilinos-develop-m7i5m3n7t54wtfuxzq4papu3scxbezkt/spack-src/packages/shylu/shylu_node/tacho/unit-test/Tacho_TestSerial_double.cpp:1:10: fatal error: 'gtest/gtest.h' file not found 21836 #include <gtest/gtest.h>

Maybe Tacho needs to require Gtest for this unit test?

cmake \
-DTrilinos_ENABLE_TESTS:BOOL=ON
-DTrilinos_ENABLE_EXAMPLES:BOOL=ON
-DTrilinos_ENABLE_ALL_PACKAGES:BOOL=ON
-DTrilinos_TRACE_ADD_TEST:BOOL=ON
-DTrilinos_ENABLE_CONFIGURE_TIMING:BOOL=ON
-DTrilinos_HOSTNAME:STRING=redwood
-DTrilinos_CONFIGURE_OPTIONS_FILE:STRING=cmake/std/atdm/ATDMDevEnv.cmake;cmake/std/atdm/apps/empire/EMPIRETrilinosEnables.cmake

Curiously, the CMake output shows:

-- Setting ShyLU_NodeTacho_ENABLE_TESTS=OFF because ShyLU_NodeTacho has a required test/example dependence on disabled package Gtest
-- Setting ShyLU_NodeTacho_ENABLE_EXAMPLES=OFF because ShyLU_NodeTacho has a required test/example dependence on disabled package Gtest
kyungjoo-kim commented 3 years ago

i can handle it. probably by the end of this week.

jjellio commented 3 years ago

I can post more if you want - the build is a little experimental since it's on an NDA machine.

I don't really understand why it's happening... seems the tests should be disabled!

Thanks

Processing enabled package: ShyLU_Node (Tacho, Tests, Examples)
-- ShyLU_NodeTacho_Tacho_TestUtilTaskScheduler_MPI_1: Added test (BASIC, NUM_MPI_PROCS=1, PROCESSORS=1)!
-- ShyLU_NodeTacho_Tacho_TestUtilTaskSchedulerMultiple_MPI_1: Added test (BASIC, NUM_MPI_PROCS=1, PROCESSORS=1)!
-- ShyLU_NodeTacho_Tacho_TestUtilChaseLevTaskScheduler_MPI_1: Added test (BASIC, NUM_MPI_PROCS=1, PROCESSORS=1)!
-- ShyLU_NodeTacho_Tacho_TestSerialDoubleTaskScheduler_MPI_1: Added test (BASIC, NUM_MPI_PROCS=1, PROCESSORS=1)!
-- ShyLU_NodeTacho_Tacho_TestSerialDoubleTaskSchedulerMultiple_MPI_1: Added test (BASIC, NUM_MPI_PROCS=1, PROCESSORS=1)!
-- ShyLU_NodeTacho_Tacho_TestSerialDoubleChaseLevTaskScheduler_MPI_1: Added test (BASIC, NUM_MPI_PROCS=1, PROCESSORS=1)!
-- ShyLU_NodeTacho_Tacho_TestSerialDoubleComplexTaskScheduler_MPI_1: Added test (BASIC, NUM_MPI_PROCS=1, PROCESSORS=1)!
-- ShyLU_NodeTacho_Tacho_TestSerialDoubleComplexTaskSchedulerMultiple_MPI_1: Added test (BASIC, NUM_MPI_PROCS=1, PROCESSORS=1)!
-- ShyLU_NodeTacho_Tacho_TestSerialDoubleComplexChaseLevTaskScheduler_MPI_1: Added test (BASIC, NUM_MPI_PROCS=1, PROCESSORS=1)!
csiefer2 commented 3 years ago

I've found that Tacho really, really, wants to turn Gtest on, no matter how hard I try to turn it off..

jjellio commented 3 years ago

Yeah well, I really really want it off - care to step outside?

kyungjoo-kim commented 3 years ago

how can I run your script ? how can I indicate the repo directory ? 

cmake \                                                                                                       
    -DTrilinos_ENABLE_TESTS:BOOL=ON \                                                                         
    -DTrilinos_ENABLE_EXAMPLES:BOOL=ON \                                                                      
    -DTrilinos_ENABLE_ALL_PACKAGES:BOOL=ON \                                                                  
    -DTrilinos_TRACE_ADD_TEST:BOOL=ON \                                                                       
    -DTrilinos_ENABLE_CONFIGURE_TIMING:BOOL=ON \                                                              
    -DTrilinos_HOSTNAME:STRING=blake \                                                                        
    -DTrilinos_CONFIGURE_OPTIONS_FILE:STRING=cmake/std/atdm/ATDMDevEnv.cmake;cmake/std/atdm/apps/empire/EMPIRETrilinosEnables.cmake \   
    ${HOME}/Work/lib/trilinos/master

This does not work on blake. 

CMake Error: The source directory "/ascldap/users/kyukim/Work/lib/trilinos/build/blake/tacho/temp" does not appear to contain CMakeLists.txt.
Specify --help for usage, or press the help button on the CMake GUI.
-bash: cmake/std/atdm/apps/empire/EMPIRETrilinosEnables.cmake: No such file or directory

The temp directory is my buld directory; not the repo directory. Do I need to use envrionment variables for this script ?

jjellio commented 3 years ago

The default ATDM build process should work, that's got an unquoted semi colon causing problems

# not sure if Blake has this stuff
trilinos_path/cmake/std/atdm/load-env.sh blake-gnu-serial-release-shared

cmake \                                                                                                       
    -DTrilinos_ENABLE_TESTS:BOOL=ON \                                                                         
    -DTrilinos_ENABLE_EXAMPLES:BOOL=ON \                                                                      
    -DTrilinos_ENABLE_ALL_PACKAGES:BOOL=ON \                                                                  
    -DTrilinos_TRACE_ADD_TEST:BOOL=ON \                                                                       
    -DTrilinos_ENABLE_CONFIGURE_TIMING:BOOL=ON \                                                              
    -DTrilinos_HOSTNAME:STRING=blake \                                                                        
    -D"Trilinos_CONFIGURE_OPTIONS_FILE:STRING=cmake/std/atdm/ATDMDevEnv.cmake;cmake/std/atdm/apps/empire/EMPIRETrilinosEnables.cmake" \   
    ${HOME}/Work/lib/trilinos/master
kyungjoo-kim commented 3 years ago

Where should I test for ATDM build script ? Would you pick on SON test bed ? 

Error, could not determine a system configuration for hostname='blake.sandia.gov', aborting env loading script!
jjellio commented 3 years ago

Hm - if you can build Tacho on blake (however you want) - or mabye anywhere, that will probably produce the problem. EMPIRE's script is just going to set TPL_ENABLE_Gtest=OFF or something like that.

jjellio commented 3 years ago

The ATDM stuff just going to enable SuperLUDist, BLAS,LAPACK, ParMETIS, METIS, Boost, cgns, NetCDF, PNetCDF...

SEMS provides this stuff, but I haven't used it recently, you use 'rhel7' as the trilinos_path/cmake/std/atdm/load-env.sh rhel7-gnu-serial-release-shared (I think) been a while.

jjellio commented 3 years ago

I have something like the following on a SNL desktop (using SEMS)


module purge
module load  sems-env sems-git/2.10.1 sems-cmake/3.19.1 sems-ninja_fortran/1.10.0 sems-gcc/7.2.0 sems-openmpi/1.10.1

TRILINOS=$(realpath ..)
source $TRILINOS/cmake/std/atdm/load-env.sh sems-rhel7-gnu-release-shared-serial

#  -D Trilinos_CONFIGURE_OPTIONS_FILE:STRING=cmake/std/atdm/ATDMDevEnv.cmake,cmake/std/atdm/apps/empire/EMPIRETrilinosEnables.cmake \

... the stuff
kyungjoo-kim commented 3 years ago

I can compile Tacho with Trilinos_ENABLE_Gtest=OFF. I just cannot see verbose output of adding tests.

Processing enabled package: ShyLU_Node (Tacho, Tests, Examples)
-- ShyLU_NodeTacho_Tacho_TestUtilTaskScheduler_MPI_1: Added test (BASIC, NUM_MPI_PROCS=1, PROCESSORS=1)!

Do you know what flag I should use for verbose output of added tests ?

jjellio commented 3 years ago

Not really sure to be honest, I posted my configure line. -DTrilinos_TRACE_ADD_TEST:BOOL=ON you'd think that would do it, but maybe not.

kyungjoo-kim commented 3 years ago

BTW, which cmake variable do you want for Tacho to respect ? Trilinos_ENABLE_Gtest or TPL_ENABLE_gtest ?

jjellio commented 3 years ago

I was using cmake 3.19 if that makes a difference... but I thought Trilinos now requires a high version anyway

kyungjoo-kim commented 3 years ago

Tests are disabled from cmake when I disable trilinos flag. The tpl flag does not impact overall configuration.

jjellio commented 3 years ago

I'd check the EMPIRE cmake file, it disables it.

jjellio commented 3 years ago

Here: https://github.com/trilinos/Trilinos/blob/master/cmake/std/atdm/apps/empire/EMPIRETrilinosEnables.cmake

jjellio commented 3 years ago 

ATDM_SET_CACHE(Gtest_SKIP_INSTALL TRUE CACHE BOOL)
# NOTE: Above, we have to set Gtest_SKIP_INSTALL=TRUE here just for EMPIRE for
# now and not in ATDMDevEnvSetting.cmake because SPARC currently must have
# gtest installed from Trilinos to build any tests.  See Trilinos GitHub
# #5341.  (Once we can get SPARC to have its own gtest, then we can move this
# setting to ATDMDevEnvSettings.cmake. See SPAR-614.)

ATDM_SET_CACHE(Trilinos_ENABLE_Gtest FALSE CACHE BOOL)

So it's setting Trilinos_ENABLE_Gtest=OFF

kyungjoo-kim commented 3 years ago

I somehow cannot reproduce the behavior. When I disable Gtest, it disables example and tests

[kyukim @kokkos-dev-2] tacho > ls
CMakeFiles  cmake_install.cmake  CTestTestfile.cmake  Makefile  Makefile.export.ShyLU_NodeTacho  ShyLU_NodeTachoConfig.cmake  src

This just shows src directory only.

kyungjoo-kim commented 3 years ago

This is a bit long log. The code enables Tacho and disable Gtest. 


[kyukim @kokkos-dev-2] test > . ../run-conf-tacho-host.sh |& tee log 

Configuring Trilinos build directory

-- PROJECT_SOURCE_DIR='/ascldap/users/kyukim/Work/lib/trilinos/tmp'
-- PROJECT_BINARY_DIR='/ascldap/users/kyukim/Work/lib/trilinos/build/kokkos-dev-2/tacho/test'
-- Trilinos_TRIBITS_DIR='/ascldap/users/kyukim/Work/lib/trilinos/tmp/cmake/tribits'
-- TriBITS_VERSION_STRING='0.9 (Dev)'
-- CMAKE_VERSION='3.19.1'
-- CMAKE_GENERATOR='Unix Makefiles'
-- CMAKE_HOST_SYSTEM_NAME='Linux'
-- Trilinos_HOSTNAME='kokkos-dev-2'
-- Found PythonInterp: /projects/sems/install/rhel7-x86_64/sems/compiler/python/2.7.9/bin/python (found suitable version "2.7.9", minimum required is "2.6") 
-- PYTHON_EXECUTABLE='/projects/sems/install/rhel7-x86_64/sems/compiler/python/2.7.9/bin/python'
-- Found Git: /usr/bin/git (found version "1.8.3.1") 

Setting up major user options ...

***
*** NOTE: Setting Trilinos_ENABLE_PyTrilinos=OFF because BUILD_SHARED_LIBS=OFF!
***

-- Setting Trilinos_ENABLE_TriKota=OFF because '/ascldap/users/kyukim/Work/lib/trilinos/tmp/packages/TriKota/Dakota' does not exist!

Trilinos repos versions:
--------------------------------------------------------------------------------
*** Base Git Repo: Trilinos
cfb0c1d [Wed Apr 7 16:02:04 2021 -0600] <trilinos@sandia.gov>
Merge Pull Request #8986 from dridzal/Trilinos/rol-trilinos-sync
 --------------------------------------------------------------------------------

Reading list of native packages from /ascldap/users/kyukim/Work/lib/trilinos/tmp/PackagesList.cmake

-- Trilinos_NUM_PACKAGES='64'

Reading list of native TPLs from /ascldap/users/kyukim/Work/lib/trilinos/tmp/TPLsList.cmake

-- Trilinos_NUM_TPLS='116'

Processing Project, Repository, and Package dependency files and building internal dependencies graph ...

-- Trilinos_NUM_SE_PACKAGES='159'
-- Tentatively enabling TPL 'DLlib'

Explicitly enabled packages on input (by user):  0

Explicitly enabled SE packages on input (by user):  ShyLU_NodeTacho 1

Explicitly disabled packages on input (by user or by default):  Gtest TriKota PyTrilinos NewPackage 4

Explicitly disabled SE packages on input (by user or by default):  Gtest ShyLU_NodeBasker ShyLU_NodeFastILU SEACASExotec2 SEACASSlice TriKota ShyLU_DDCore PanzerExprEval PyTrilinos NewPackage 10

Explicitly enabled TPLs on input (by user):  BLAS LAPACK METIS DLlib 4

Explicitly disabled TPLs on input (by user or by default):  CUDA CUSPARSE MPI 3

Disabling all packages that have a required dependency on disabled TPLs and optional package TPL support based on TPL_ENABLE_<TPL>=OFF ...

-- Setting Trilinos_ENABLE_STKCoupling=OFF because STKCoupling has a required library dependence on disabled TPL MPI
-- Setting Trilinos_ENABLE_STKMesh=OFF because STKMesh has a required library dependence on disabled TPL MPI
-- Setting Trilinos_ENABLE_STKSearch=OFF because STKSearch has a required library dependence on disabled TPL MPI
-- Setting Trilinos_ENABLE_ShyLU_DDBDDC=OFF because ShyLU_DDBDDC has a required library dependence on disabled TPL MPI
-- Setting Trilinos_ENABLE_ShyLU_DDFROSch=OFF because ShyLU_DDFROSch has a required library dependence on disabled TPL MPI
-- Setting Trilinos_ENABLE_PanzerDofMgr=OFF because PanzerDofMgr has a required library dependence on disabled TPL MPI
-- Setting Trilinos_ENABLE_PanzerDiscFE=OFF because PanzerDiscFE has a required library dependence on disabled TPL MPI
-- Setting Trilinos_ENABLE_PanzerMiniEM=OFF because PanzerMiniEM has a required library dependence on disabled TPL MPI
-- Setting Trilinos_ENABLE_PikeBlackBox=OFF because PikeBlackBox has a required library dependence on disabled TPL MPI

Disabling subpackages for hard disables of parent packages due to Trilinos_ENABLE_<PARENT_PACKAGE>=OFF ...

Disabling forward required SE packages and optional intra-package support that have a dependancy on disabled SE packages Trilinos_ENABLE_<TRIBITS_PACKAGE>=OFF ...

-- Setting Trilinos_ENABLE_STKNGP_TEST=OFF because STKNGP_TEST has a required library dependence on disabled package Gtest
-- Setting MiniTensor_ENABLE_TESTS=OFF because MiniTensor has a required test/example dependence on disabled package Gtest
-- Setting MiniTensor_ENABLE_EXAMPLES=OFF because MiniTensor has a required test/example dependence on disabled package Gtest
-- Setting ShyLU_NodeTacho_ENABLE_TESTS=OFF because ShyLU_NodeTacho has a required test/example dependence on disabled package Gtest
-- Setting ShyLU_NodeTacho_ENABLE_EXAMPLES=OFF because ShyLU_NodeTacho has a required test/example dependence on disabled package Gtest
-- Setting Intrepid_ENABLE_TESTS=OFF because Intrepid has a required test/example dependence on disabled package Gtest
-- Setting Intrepid_ENABLE_EXAMPLES=OFF because Intrepid has a required test/example dependence on disabled package Gtest
-- Setting STKUtil_ENABLE_TESTS=OFF because STKUtil has a required test/example dependence on disabled package Gtest
-- Setting STKUtil_ENABLE_EXAMPLES=OFF because STKUtil has a required test/example dependence on disabled package Gtest
-- Setting STKMath_ENABLE_TESTS=OFF because STKMath has a required test/example dependence on disabled package Gtest
-- Setting STKMath_ENABLE_EXAMPLES=OFF because STKMath has a required test/example dependence on disabled package Gtest
-- Setting STKSimd_ENABLE_TESTS=OFF because STKSimd has a required test/example dependence on disabled package Gtest
-- Setting STKSimd_ENABLE_EXAMPLES=OFF because STKSimd has a required test/example dependence on disabled package Gtest
-- Setting STKIO_ENABLE_TESTS=OFF because STKIO has a required test/example dependence on disabled package Gtest
-- Setting STKIO_ENABLE_EXAMPLES=OFF because STKIO has a required test/example dependence on disabled package Gtest
-- Setting STKUnit_test_utils_ENABLE_TESTS=OFF because STKUnit_test_utils has a required test/example dependence on disabled package Gtest
-- Setting STKUnit_test_utils_ENABLE_EXAMPLES=OFF because STKUnit_test_utils has a required test/example dependence on disabled package Gtest
-- Setting STKSearchUtil_ENABLE_TESTS=OFF because STKSearchUtil has a required test/example dependence on disabled package Gtest
-- Setting STKSearchUtil_ENABLE_EXAMPLES=OFF because STKSearchUtil has a required test/example dependence on disabled package Gtest
-- Setting STKTools_ENABLE_TESTS=OFF because STKTools has a required test/example dependence on disabled package Gtest
-- Setting STKTools_ENABLE_EXAMPLES=OFF because STKTools has a required test/example dependence on disabled package Gtest
-- Setting STKBalance_ENABLE_TESTS=OFF because STKBalance has a required test/example dependence on disabled package Gtest
-- Setting STKBalance_ENABLE_EXAMPLES=OFF because STKBalance has a required test/example dependence on disabled package Gtest
-- Setting STKUnit_tests_ENABLE_TESTS=OFF because STKUnit_tests has a required test/example dependence on disabled package Gtest
-- Setting STKUnit_tests_ENABLE_EXAMPLES=OFF because STKUnit_tests has a required test/example dependence on disabled package Gtest
-- Setting STKDoc_tests_ENABLE_TESTS=OFF because STKDoc_tests has a required test/example dependence on disabled package Gtest
-- Setting STKDoc_tests_ENABLE_EXAMPLES=OFF because STKDoc_tests has a required test/example dependence on disabled package Gtest
-- Setting STKExprEval_ENABLE_TESTS=OFF because STKExprEval has a required test/example dependence on disabled package Gtest
-- Setting STKExprEval_ENABLE_EXAMPLES=OFF because STKExprEval has a required test/example dependence on disabled package Gtest
-- Setting Trilinos_ENABLE_STKUnit_test_utils=OFF because STKUnit_test_utils has a required library dependence on disabled package STKNGP_TEST
-- Setting Trilinos_ENABLE_STKIO=OFF because STKIO has a required library dependence on disabled package STKMesh
-- Setting Trilinos_ENABLE_STKSearchUtil=OFF because STKSearchUtil has a required library dependence on disabled package STKMesh
-- Setting Trilinos_ENABLE_STKTools=OFF because STKTools has a required library dependence on disabled package STKMesh
-- Setting Trilinos_ENABLE_STKBalance=OFF because STKBalance has a required library dependence on disabled package STKMesh
-- Setting Trilinos_ENABLE_Percept=OFF because Percept has a required library dependence on disabled package STKMesh
-- Setting Trilinos_ENABLE_PanzerAdaptersSTK=OFF because PanzerAdaptersSTK has a required library dependence on disabled package STKMesh
-- Setting Trilinos_ENABLE_STKTransfer=OFF because STKTransfer has a required library dependence on disabled package STKSearch
-- Setting Trilinos_ENABLE_ShyLU_DD=OFF because ShyLU_DD has a required library dependence on disabled package ShyLU_DDBDDC
-- Setting Trilinos_ENABLE_ShyLU=OFF because ShyLU has a required library dependence on disabled package ShyLU_DD
-- Setting Trilinos_ENABLE_PikeImplicit=OFF because PikeImplicit has a required library dependence on disabled package PikeBlackBox

Enabling subpackages for hard enables of parent packages due to Trilinos_ENABLE_<PARENT_PACKAGE>=ON ...

Enabling all tests and/or examples that have not been explicitly disabled because Trilinos_ENABLE_[TESTS,EXAMPLES]=ON ...

Enabling all required upstream SE packages for current set of enabled packages (Trilinos_ENABLE_SECONDARY_TESTED_CODE=ON) ...

-- Setting Trilinos_ENABLE_Kokkos=ON because ShyLU_NodeTacho has a required dependence on Kokkos
-- Setting Trilinos_ENABLE_KokkosAlgorithms=ON because ShyLU_NodeTacho has a required dependence on KokkosAlgorithms
-- Setting Trilinos_ENABLE_KokkosCore=ON because Kokkos has a required dependence on KokkosCore
-- Setting Trilinos_ENABLE_KokkosContainers=ON because KokkosAlgorithms has a required dependence on KokkosContainers

Enabling all optional intra-package enables <TRIBITS_PACKAGE>_ENABLE_<DEPPACKAGE> that are not currently disabled if both sets of packages are enabled ...

-- Setting Kokkos_ENABLE_KokkosContainers=ON since Trilinos_ENABLE_Kokkos=ON AND Trilinos_ENABLE_KokkosContainers=ON
-- Setting Kokkos_ENABLE_KokkosAlgorithms=ON since Trilinos_ENABLE_Kokkos=ON AND Trilinos_ENABLE_KokkosAlgorithms=ON

Enabling all remaining required TPLs for current set of enabled packages ...

Enabling all optional package TPL support <TRIBITS_PACKAGE>_ENABLE_<DEPTPL> not currently disabled for enabled TPLs ...

-- Setting KokkosCore_ENABLE_DLlib=ON since TPL_ENABLE_DLlib=ON
-- Setting ShyLU_NodeTacho_ENABLE_METIS=ON since TPL_ENABLE_METIS=ON
-- Setting ShyLU_NodeTacho_ENABLE_LAPACK=ON since TPL_ENABLE_LAPACK=ON
-- Setting ShyLU_NodeTacho_ENABLE_BLAS=ON since TPL_ENABLE_BLAS=ON
-- NOTE: ShyLU_NodeTacho_ENABLE_METIS=ON is already set!
-- NOTE: ShyLU_NodeTacho_ENABLE_LAPACK=ON is already set!
-- NOTE: ShyLU_NodeTacho_ENABLE_BLAS=ON is already set!

Enabling TPLs based on <TRIBITS_PACKAGE>_ENABLE_<TPL>=ON if TPL is not explicitly disabled ...

Set cache entries for optional packages/TPLs and tests/examples for packages actually enabled ...

Enabling the shell of non-enabled parent packages (mostly for show) that have at least one subpackage enabled ...

-- Setting Trilinos_ENABLE_ShyLU_Node=ON because Trilinos_ENABLE_ShyLU_NodeTacho=ON

Final set of enabled packages:  Kokkos ShyLU_Node 2

Final set of enabled SE packages:  KokkosCore KokkosContainers KokkosAlgorithms Kokkos ShyLU_NodeTacho ShyLU_Node 6

Final set of non-enabled packages:  TrilinosFrameworkTests TrilinosATDMConfigTests Gtest Teuchos KokkosKernels RTOp Sacado MiniTensor Epetra Zoltan Shards Triutils EpetraExt Tpetra TrilinosSS Domi Thyra Xpetra Isorropia Pliris AztecOO Galeri Amesos Pamgen Zoltan2Core Ifpack ML Belos Amesos2 SEACAS Komplex Anasazi Ifpack2 Stratimikos FEI Teko TriKota Intrepid Intrepid2 Compadre STK Percept Phalanx NOX Moertel MueLu Zoltan2Sphynx Zoltan2 ShyLU_DD ShyLU Rythmos Tempus Stokhos ROL Piro Panzer PyTrilinos NewPackage Adelus TrilinosCouplings Pike TrilinosBuildStats 62

Final set of non-enabled SE packages:  TrilinosFrameworkTests TrilinosATDMConfigTests Gtest TeuchosCore TeuchosParser TeuchosParameterList TeuchosComm TeuchosNumerics TeuchosRemainder TeuchosKokkosCompat TeuchosKokkosComm Teuchos KokkosKernels RTOp Sacado MiniTensor Epetra Zoltan Shards Triutils EpetraExt TpetraClassic TpetraTSQR TpetraCore Tpetra TrilinosSS Domi ThyraCore ThyraEpetraAdapters ThyraEpetraExtAdapters ThyraTpetraAdapters Thyra Xpetra Isorropia Pliris AztecOO Galeri Amesos Pamgen Zoltan2Core Ifpack ML Belos ShyLU_NodeHTS ShyLU_NodeBasker ShyLU_NodeFastILU Amesos2 SEACASExodus SEACASExodus_for SEACASExoIIv2for32 SEACASNemesis SEACASIoss SEACASChaco SEACASAprepro_lib SEACASSupes SEACASSuplib SEACASSuplibC SEACASSuplibCpp SEACASSVDI SEACASPLT SEACASAlgebra SEACASAprepro SEACASBlot SEACASConjoin SEACASEjoin SEACASEpu SEACASExo2mat SEACASExodiff SEACASExomatlab SEACASExotxt SEACASExo_format SEACASEx1ex2v2 SEACASExotec2 SEACASFastq SEACASGjoin SEACASGen3D SEACASGenshell SEACASGrepos SEACASExplore SEACASMapvarlib SEACASMapvar SEACASMapvar-kd SEACASMat2exo SEACASNas2exo SEACASZellij SEACASNemslice SEACASNemspread SEACASNumbers SEACASSlice SEACASTxtexo SEACASEx2ex1v2 SEACAS Komplex Anasazi Ifpack2 Stratimikos FEI Teko TriKota Intrepid Intrepid2 Compadre STKUtil STKCoupling STKMath STKSimd STKNGP_TEST STKTopology STKMesh STKIO STKUnit_test_utils STKSearch STKSearchUtil STKTransfer STKTools STKBalance STKUnit_tests STKDoc_tests STKExprEval STK Percept Phalanx NOX Moertel MueLu Zoltan2Sphynx Zoltan2 ShyLU_DDBDDC ShyLU_DDFROSch ShyLU_DDCore ShyLU_DDCommon ShyLU_DD ShyLU Rythmos Tempus Stokhos ROL Piro PanzerCore PanzerDofMgr PanzerDiscFE PanzerAdaptersSTK PanzerMiniEM PanzerExprEval Panzer PyTrilinos NewPackage Adelus TrilinosCouplings PikeBlackBox PikeImplicit Pike TrilinosBuildStats 153

Final set of enabled TPLs:  BLAS LAPACK METIS DLlib 4

Final set of non-enabled TPLs:  MKL yaml-cpp Peano CUDA CUBLAS CUSOLVER CUSPARSE Thrust Cusp TBB Pthread HWLOC QTHREAD BinUtils ARPREC QD MPI Boost Scotch OVIS gpcd MTMETIS ParMETIS PuLP TopoManager LibTopoMap PaToH CppUnit ADOLC ADIC TVMET MF ExodusII Nemesis XDMF Zlib HDF5 CGNS Pnetcdf Netcdf ADIOS2 y12m SuperLUDist SuperLUMT SuperLU Cholmod UMFPACK MA28 AMD CSparse HYPRE PETSC BLACS SCALAPACK MUMPS STRUMPACK PARDISO_MKL PARDISO Oski TAUCS ForUQTK Dakota HIPS MATLAB CASK SPARSKIT QT gtest BoostLib BoostAlbLib OpenNURBS Portals CrayPortals Gemini InfiniBand BGPDCMF BGQPAMI Pablo HPCToolkit Clp GLPK qpOASES Matio PAPI MATLABLib Eigen X11 Lemon GLM quadmath CAMAL RTlib AmgX CGAL CGALCore VTune TASMANIAN ArrayFireCPU SimMesh SimModel SimParasolid SimAcis SimField Valgrind QUO ViennaCL Avatar mlpack pebbl MAGMASparse Check SARMA 112

Setting up export dependencies for all enabled SE packages ...

Probing the environment ...

-- USE_XSDK_DEFAULTS='FALSE'
-- BUILD_SHARED_LIBS='OFF'
-- CMAKE_BUILD_TYPE='RELEASE'
-- The C compiler identification is GNU 6.1.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /projects/sems/install/rhel7-x86_64/sems/compiler/gcc/6.1.0/base/bin/gcc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- CMAKE_C_COMPILER_ID='GNU'
-- CMAKE_C_COMPILER_VERSION='6.1.0'
-- The CXX compiler identification is GNU 6.1.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /projects/sems/install/rhel7-x86_64/sems/compiler/gcc/6.1.0/openmpi/1.10.1/bin/mpicxx - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- CMAKE_CXX_COMPILER_ID='GNU'
-- CMAKE_CXX_COMPILER_VERSION='6.1.0'
-- Skip adding flags for OpenMP because Kokkos flags does that ...
-- Trilinos_SET_INSTALL_RPATH='TRUE'
-- CMAKE_INSTALL_RPATH_USE_LINK_PATH='TRUE'
-- Setting default for CMAKE_INSTALL_RPATH pointing to Trilinos_INSTALL_LIB_DIR
-- CMAKE_INSTALL_RPATH='/ascldap/users/kyukim/Work/lib/trilinos/install/kokkos-dev-2/tacho/OPENMP/lib'
-- Looking for C++ include sys/time.h
-- Looking for C++ include sys/time.h - found
-- Looking for C++ include time.h
-- Looking for C++ include time.h - found
-- Looking for C++ include stdint.h
-- Looking for C++ include stdint.h - found
-- Looking for C++ include inttypes.h
-- Looking for C++ include inttypes.h - found
-- Found Perl: /usr/bin/perl (found version "5.16.3") 
-- Found OpenMP_C: -fopenmp (found version "4.5") 
-- Found OpenMP_CXX: -fopenmp (found version "4.5") 
-- Found OpenMP: TRUE (found version "4.5")  
-- Performing Test MATH_LIBRARY_IS_SUPPLIED
-- Performing Test MATH_LIBRARY_IS_SUPPLIED - Success
-- Performing Test FINITE_VALUE_HAVE_GLOBAL_ISNAN
-- Performing Test FINITE_VALUE_HAVE_GLOBAL_ISNAN - Success
-- Performing Test FINITE_VALUE_HAVE_STD_ISNAN
-- Performing Test FINITE_VALUE_HAVE_STD_ISNAN - Success
-- Performing Test FINITE_VALUE_HAVE_GLOBAL_ISINF
-- Performing Test FINITE_VALUE_HAVE_GLOBAL_ISINF - Success
-- Performing Test FINITE_VALUE_HAVE_STD_ISINF
-- Performing Test FINITE_VALUE_HAVE_STD_ISINF - Success
-- Found Doxygen: /usr/bin/doxygen (found version "1.8.5") found components: doxygen dot 

Getting information for all enabled TPLs ...

Processing enabled TPL: BLAS (enabled explicitly, disable with -DTPL_ENABLE_BLAS=OFF)
-- BLAS_LIBRARY_NAMES='blas blas_win32'
-- TPL_BLAS_LIBRARIES='-lblas -lgfortran'
Processing enabled TPL: LAPACK (enabled explicitly, disable with -DTPL_ENABLE_LAPACK=OFF)
-- LAPACK_LIBRARY_NAMES='lapack lapack_win32'
-- TPL_LAPACK_LIBRARIES='-llapack'
Processing enabled TPL: METIS (enabled explicitly, disable with -DTPL_ENABLE_METIS=OFF)
-- METIS_LIBRARY_NAMES='metis'
-- Searching for libs in METIS_LIBRARY_DIRS='/projects/sems/install/rhel7-x86_64/sems/tpl/metis/5.1.0/gcc/6.1.0/base/lib'
-- Searching for a lib in the set "metis":
--   Searching for lib 'metis' ...
--     Found lib '/projects/sems/install/rhel7-x86_64/sems/tpl/metis/5.1.0/gcc/6.1.0/base/lib/libmetis.a'
-- TPL_METIS_LIBRARIES='/projects/sems/install/rhel7-x86_64/sems/tpl/metis/5.1.0/gcc/6.1.0/base/lib/libmetis.a'
-- Searching for headers in METIS_INCLUDE_DIRS='/projects/sems/install/rhel7-x86_64/sems/tpl/metis/5.1.0/gcc/6.1.0/base/include'
-- Searching for a header file in the set "metis.h":
--   Searching for header 'metis.h' ...
--     Found header '/projects/sems/install/rhel7-x86_64/sems/tpl/metis/5.1.0/gcc/6.1.0/base/include/metis.h'
-- Found TPL 'METIS' include dirs '/projects/sems/install/rhel7-x86_64/sems/tpl/metis/5.1.0/gcc/6.1.0/base/include'
-- TPL_METIS_INCLUDE_DIRS='/projects/sems/install/rhel7-x86_64/sems/tpl/metis/5.1.0/gcc/6.1.0/base/include'
Processing enabled TPL: DLlib (enabled explicitly, disable with -DTPL_ENABLE_DLlib=OFF)
-- Attempting to tentatively enable TPL 'DLlib' ...
-- DLlib_LIBRARY_NAMES='dl'
-- Searching for libs in DLlib_LIBRARY_DIRS=''
-- Searching for a lib in the set "dl":
--   Searching for lib 'dl' ...
--     Found lib '/usr/lib64/libdl.so'
-- TPL_DLlib_LIBRARIES='/usr/lib64/libdl.so'
-- Attempt to tentatively enable TPL 'DLlib' passed!

Setting up testing support ...

-- CTEST_DROP_METHOD='http'
-- CTEST_DROP_SITE='testing.sandia.gov'
-- CTEST_PROJECT_NAME='Trilinos'
-- CTEST_DROP_LOCATION='/cdash/submit.php?project=Trilinos'
-- CTEST_TRIGGER_SITE=''
-- CTEST_DROP_SITE_CDASH='TRUE'
-- TRIBITS_2ND_CTEST_DROP_SITE='testing-dev.sandia.gov'
-- TRIBITS_2ND_CTEST_DROP_LOCATION='/cdash/submit.php?project=Trilinos'

Configuring individual enabled Trilinos packages ...

-- NOTE: Can't fill in version date files for Trilinos since GIT_VERSION_STRING=1.8.3.1 < 2.10.0
Processing enabled package: Kokkos (Core, Containers, Algorithms, Tests)
-- Setting default Kokkos CXX standard to 14
-- Setting policy CMP0074 to use <Package>_ROOT variables
-- CTEST_DROP_SITE='testing.sandia.gov'
-- CTEST_PROJECT_NAME='Trilinos'
-- CTEST_DROP_LOCATION='/cdash/submit.php?project=Trilinos'
-- CTEST_TRIGGER_SITE=''
-- CTEST_DROP_SITE_CDASH='TRUE'
-- TRIBITS_2ND_CTEST_DROP_SITE='testing-dev.sandia.gov'
-- TRIBITS_2ND_CTEST_DROP_LOCATION='/cdash/submit.php?project=Trilinos'
-- CTEST_DROP_SITE='testing.sandia.gov'
-- CTEST_PROJECT_NAME='Trilinos'
-- CTEST_DROP_LOCATION='/cdash/submit.php?project=Trilinos'
-- CTEST_TRIGGER_SITE=''
-- CTEST_DROP_SITE_CDASH='TRUE'
-- TRIBITS_2ND_CTEST_DROP_SITE='testing-dev.sandia.gov'
-- TRIBITS_2ND_CTEST_DROP_LOCATION='/cdash/submit.php?project=Trilinos'
-- The project name is: Trilinos
CMake Warning at packages/kokkos/cmake/kokkos_enable_options.cmake:89 (MESSAGE):
  Kokkos_ENABLE_CUDA_UVM is ON but CUDA backend is not enabled.  Option will
  be ignored.
Call Stack (most recent call first):
  packages/kokkos/cmake/kokkos_enable_options.cmake:96 (CHECK_DEVICE_SPECIFIC_OPTIONS)
  packages/kokkos/cmake/kokkos_tribits.cmake:215 (INCLUDE)
  packages/kokkos/CMakeLists.txt:168 (KOKKOS_SETUP_BUILD_ENVIRONMENT)

CMake Warning at packages/kokkos/cmake/kokkos_enable_options.cmake:89 (MESSAGE):
  Kokkos_ENABLE_CUDA_LAMBDA is ON but CUDA backend is not enabled.  Option
  will be ignored.
Call Stack (most recent call first):
  packages/kokkos/cmake/kokkos_enable_options.cmake:96 (CHECK_DEVICE_SPECIFIC_OPTIONS)
  packages/kokkos/cmake/kokkos_tribits.cmake:215 (INCLUDE)
  packages/kokkos/CMakeLists.txt:168 (KOKKOS_SETUP_BUILD_ENVIRONMENT)

-- Using -std=c++14 for C++14 standard as feature
-- Built-in Execution Spaces:
--     Device Parallel: NoTypeDefined
--     Host Parallel: Kokkos::OpenMP
--       Host Serial: SERIAL
-- 
-- Architectures:
--  SNB
-- Sources TestOpenMP.cpp
-- Kokkos Devices: OPENMP;SERIAL, Kokkos Backends: OPENMP;SERIAL
Processing enabled package: ShyLU_Node (Tacho)

No ETI support requested by packages.

Set up for creating a distribution ...

Finished configuring Trilinos!

-- Configuring done
-- Generating done
-- Build files have been written to: /ascldap/users/kyukim/Work/lib/trilinos/build/kokkos-dev-2/tacho/test```
jjellio commented 3 years ago

Are you using the EMPIRE cmake? it's going to enable/disable things. The top level cmake thing is enabling everything as well (EMPIRE may just be disable Gtest)


cmake \                                                                                                       
    -DTrilinos_ENABLE_TESTS:BOOL=ON \                                                                         
    -DTrilinos_ENABLE_EXAMPLES:BOOL=ON \                                                                      
    -DTrilinos_ENABLE_ALL_PACKAGES:BOOL=ON \    ```
kyungjoo-kim commented 3 years ago

I can make a guard with gtest variable on my fork branch. Would you like to test it ?

kyungjoo-kim commented 3 years ago

Would you try the PR #8990 and see if it fixes your problem ? I somehow cannot reproduce the same behavior and I am not very familiar with the ATDM build script.

jjellio commented 3 years ago

~~Probably later today or tomorrow. I'm stuck in the middle of dirty source tree right now =\ ~~

I've added the patch to my build script, so we'll see

jjellio commented 3 years ago

No afraid not.

FAILED: packages/shylu/shylu_dd/bddc/test/CMakeFiles/ShyLU_DDBDDC_shylubddc_unit_tests.dir/SparseSolverTest.cpp.o

Is it all of shylu that depends on Gtest? I'm curious because if I do CI testing using EMPIRE's settings, these packages won't get unit tested at all... (hope they don't use them!)

kyungjoo-kim commented 3 years ago

I think that the BDDC is written by @crdohrm and I believe it uses gtest internally. So, the main question is why those tests are enalbed even though the gtest dependency should disable them. I can change the cmake explicitly exclude the BDDC tests when gtest is not enabled.

jjellio commented 3 years ago

I have no idea - I'm just launching with ATDMDevSettings + EMPIRE's cmake thing... you'd think that would be causing other builds to fail, but maybe CI testing isn't using EMPIRE's settings?

This matters to me, because Cray wants ATDM builds (sparc/empire) so we can run each build through the toolchains (regularly) - I don't really understand how these things are getting enabled? If you depend on Gtest, shoudln't it not add them?

kyungjoo-kim commented 3 years ago

I updated the PR for the work-around. I think that the cmake logic does not work as it is supposed to be. First, let's see if this at least help you move forward.

kyungjoo-kim commented 3 years ago

Yes, it seems to be a mystery. Does this just happen in the shylu package ? not kokkos nor kokkoskernels that are dependent on gtests ? I am not sure if they are dependent some sort of internal gtest version though. If this just happen only in the shylu package, I think that explicit control of enabling tests would be a feasible solution for now. If the problem spread for several other trilinos package with gtest dependencies, it will be resolved in the cmake or the atdm script level.

jjellio commented 3 years ago

So far only in ShyLU. It’s generating about 24k targets, and the shylu parts are around 21k … so it takes a while. The build is …complicated. It’s cray + spack + more stuff (not using the official trilinos spack - using the ATDMDevSettings + EMPIRE/SPARC enables), it's then launched onto a compute node via srun, so I don't have much control (intentional) - the idea is drive CI testing using this spack+stuff process

kyungjoo-kim commented 3 years ago

Could you try the branch in the PR #8990 ? If it helps you move forward, let's just go for that work-around. Then, we can raise another issue about incorrect behavior of the cmake or the atdm scripts.

jjellio commented 3 years ago

It's merged and building.. 16k of 22k built (maybe 15 more min)

jjellio commented 3 years ago

Nope

FAILED: packages/shylu/shylu_dd/bddc/example/CMakeFiles/ShyLU_DDBDDC_simpleExample1.dir/simpleExample1.cpp.o

jjellio commented 3 years ago 
Processing enabled package: ShyLU_DD (BDDC, FROSch, Tests, Examples)
-- BDDC disables tests as Trilinos disables Gtest
-- ShyLU_DDBDDC_example1: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDBDDC_simpleExample1: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU's Epetra is being DISABLED
-- ShyLU_DDFROSch_test_import_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_interfacepartitionofunity_DIM2_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_interfacepartitionofunity_DIM3_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_interfacesets_DIM2_CSCommCrsMatrix_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_interfacesets_DIM3_CSCommCrsMatrix_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_interfacesets_DIM2_CSCommCrsGraph_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_interfacesets_DIM3_CSCommCrsGraph_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_interfacesets_DIM2_CSOneToOne_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_interfacesets_DIM3_CSOneToOne_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_localpartitionofunitybasis_TPETRA_MPI_1: Added test (BASIC, NUM_MPI_PROCS=1, PROCESSORS=1)!
-- ShyLU_DDFROSch_test_solverfactory_amesos2_klu_DIM2_TPETRA_MPI_1: Added test (BASIC, NUM_MPI_PROCS=1, PROCESSORS=1)!
-- ShyLU_DDFROSch_test_solverfactory_amesos2_klu_DIM3_TPETRA_MPI_1: Added test (BASIC, NUM_MPI_PROCS=1, PROCESSORS=1)!
-- ShyLU_DDFROSch_test_solverfactory_belos_gmres_DIM2_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_solverfactory_belos_gmres_DIM3_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_solverfactory_ifpack2_riluk_DIM2_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_solverfactory_ifpack2_riluk_DIM3_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_solverfactory_froschpreconditioner_twolevelblockpreconditioner_DIM2_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_solverfactory_froschpreconditioner_twolevelblockpreconditioner_DIM3_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_solverfactory_froschpreconditioner_twolevelpreconditioner_DIM2_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_solverfactory_froschpreconditioner_twolevelpreconditioner_DIM3_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_solverfactory_muelu_DIM2_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_solverfactory_muelu_DIM3_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_solverfactory_thyrapreconditioner_frosch_onelevelpreconditioner_DIM2_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_solverfactory_thyrapreconditioner_frosch_onelevelpreconditioner_DIM3_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_solverfactory_thyrasolver_belos_gmres_DIM2_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_solverfactory_thyrasolver_belos_gmres_DIM3_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_gathering_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_overlap_Graph_DIM2_DPN1_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_overlap_Graph_DIM2_DPN2_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_overlap_Graph_DIM3_DPN1_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_overlap_Graph_DIM3_DPN3_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_overlap_Matrix_DIM2_DPN1_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_overlap_Matrix_DIM2_DPN2_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_overlap_Matrix_DIM3_DPN1_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_overlap_Matrix_DIM3_DPN3_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_overlap_Old_DIM2_DPN1_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_overlap_Old_DIM2_DPN2_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_overlap_Old_DIM3_DPN1_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_overlap_Old_DIM3_DPN3_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_thyra_xpetra_elasticity_GDSWP_DIM2_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_thyra_xpetra_elasticity_GDSWP_DIM3_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_thyra_xpetra_elasticity_RGDSWP_DIM2_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_thyra_xpetra_elasticity_RGDSWP_DIM3_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_thyra_xpetra_elasticity_TLP_GDSW_DIM2_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_thyra_xpetra_elasticity_TLP_GDSW_DIM3_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_thyra_xpetra_elasticity_TLP_RGDSW_DIM2_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_thyra_xpetra_elasticity_TLP_RGDSW_DIM3_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_thyra_xpetra_elasticity_TLP_IPOUHarmonic_GDSW_DIM2_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_thyra_xpetra_elasticity_TLP_IPOUHarmonic_GDSW_DIM3_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_thyra_xpetra_elasticity_TLP_IPOUHarmonic_GDSW_ML_DIM2_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_thyra_xpetra_elasticity_TLP_IPOUHarmonic_GDSW_ML_DIM3_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_thyra_xpetra_elasticity_TLP_IPOUHarmonic_GDSWStar_DIM2_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_thyra_xpetra_elasticity_TLP_IPOUHarmonic_GDSWStar_DIM3_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_thyra_xpetra_elasticity_TLP_IPOUHarmonic_RGDSW_DIM2_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_thyra_xpetra_elasticity_TLP_IPOUHarmonic_RGDSW_DIM3_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_thyra_xpetra_elasticity_TLP_IPOUHarmonic_RGDSW_ML_DIM2_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_thyra_xpetra_elasticity_TLP_IPOUHarmonic_RGDSW_DIM2_TPETRA_DropCoupling_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_thyra_xpetra_elasticity_TLP_IPOUHarmonic_RGDSW_DIM3_TPETRA_DropCoupling: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- FROSch tests running with Tpetra_DefaultNode type Kokkos::Compat::KokkosSerialWrapperNode
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_GDSWP_DIM2_DPN1_ORD0_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_GDSWP_DIM2_DPN2_ORD0_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_GDSWP_DIM2_DPN2_ORD1_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_GDSWP_DIM3_DPN1_ORD0_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_GDSWP_DIM3_DPN3_ORD0_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_GDSWP_DIM3_DPN3_ORD1_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_RGDSWP_DIM2_DPN1_ORD0_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_RGDSWP_DIM2_DPN2_ORD0_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_RGDSWP_DIM2_DPN2_ORD1_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_RGDSWP_DIM3_DPN1_ORD0_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_RGDSWP_DIM3_DPN3_ORD0_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_RGDSWP_DIM3_DPN3_ORD1_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_TLP_GDSW_DIM2_DPN1_ORD0_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_TLP_GDSW_DIM2_DPN2_ORD0_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_TLP_GDSW_DIM2_DPN2_ORD1_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_TLP_GDSW_MUELU_DIM2_DPN2_ORD1_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_TLP_GDSW_DIM3_DPN1_ORD0_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_TLP_GDSW_DIM3_DPN3_ORD0_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_TLP_GDSW_DIM3_DPN3_ORD1_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_TLP_RGDSW_DIM2_DPN1_ORD0_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_TLP_RGDSW_DIM2_DPN2_ORD0_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_TLP_RGDSW_DIM2_DPN2_ORD1_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_TLP_RGDSW_DIM3_DPN1_ORD0_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_TLP_RGDSW_DIM3_DPN3_ORD0_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_TLP_RGDSW_DIM3_DPN3_ORD1_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_TLP_IPOUHarmonic_GDSW_DIM2_DPN1_ORD0_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_TLP_IPOUHarmonic_GDSW_DIM2_DPN2_ORD0_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_TLP_IPOUHarmonic_GDSW_DIM2_DPN2_ORD1_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_TLP_IPOUHarmonic_GDSW_DIM3_DPN1_ORD0_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_TLP_IPOUHarmonic_GDSW_DIM3_DPN3_ORD0_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_TLP_IPOUHarmonic_GDSW_DIM3_DPN3_ORD1_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_TLP_IPOUHarmonic_GDSW_ML_DIM2_DPN1_ORD0_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_TLP_IPOUHarmonic_GDSWStar_DIM2_DPN1_ORD0_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_TLP_IPOUHarmonic_GDSWStar_DIM2_DPN2_ORD0_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_TLP_IPOUHarmonic_GDSWStar_DIM2_DPN2_ORD1_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_TLP_IPOUHarmonic_GDSWStar_DIM3_DPN1_ORD0_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_TLP_IPOUHarmonic_GDSWStar_DIM3_DPN3_ORD0_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_TLP_IPOUHarmonic_GDSWStar_DIM3_DPN3_ORD1_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_TLP_IPOUHarmonic_RGDSW_DIM2_DPN1_ORD0_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_TLP_IPOUHarmonic_RGDSW_DIM2_DPN2_ORD0_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_TLP_IPOUHarmonic_RGDSW_DIM2_DPN2_ORD1_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_TLP_IPOUHarmonic_RGDSW_DIM3_DPN1_ORD0_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_TLP_IPOUHarmonic_RGDSW_DIM3_DPN3_ORD0_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_TLP_IPOUHarmonic_RGDSW_DIM3_DPN3_ORD1_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_TLBP_NB2_GDSW_DIM2_DPN1_ORD0_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_TLBP_NB2_GDSW_DIM2_DPN2_ORD0_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_TLBP_NB2_GDSW_DIM2_DPN1_ORD1_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_TLBP_NB2_GDSW_DIM2_DPN2_ORD1_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_TLBP_NB2_GDSW_DIM3_DPN1_ORD0_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_TLBP_NB2_GDSW_DIM3_DPN3_ORD0_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_TLBP_NB2_GDSW_DIM3_DPN1_ORD1_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_TLBP_NB2_GDSW_DIM3_DPN3_ORD1_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_TLBP_NB3_GDSW_DIM2_DPN1_ORD0_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_TLBP_NB3_GDSW_DIM2_DPN2_ORD0_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_TLBP_NB3_GDSW_DIM2_DPN1_ORD1_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_TLBP_NB3_GDSW_DIM2_DPN2_ORD1_TPETRA_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_TLBP_NB3_GDSW_DIM3_DPN1_ORD0_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_TLBP_NB3_GDSW_DIM3_DPN3_ORD0_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_TLBP_NB3_GDSW_DIM3_DPN1_ORD1_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_TLBP_NB3_GDSW_DIM3_DPN3_ORD1_TPETRA: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_one_rank_TLP_GDSW_DIM2_TPETRA_MPI_1: Added test (BASIC, NUM_MPI_PROCS=1, PROCESSORS=1)!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_one_rank_TLP_GDSW_DIM3_TPETRA_MPI_1: Added test (BASIC, NUM_MPI_PROCS=1, PROCESSORS=1)!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_one_rank_TLP_RGDSW_DIM2_TPETRA_MPI_1: Added test (BASIC, NUM_MPI_PROCS=1, PROCESSORS=1)!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_one_rank_TLP_RGDSW_DIM3_TPETRA_MPI_1: Added test (BASIC, NUM_MPI_PROCS=1, PROCESSORS=1)!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_one_rank_TLP_IPOU_DIM2_TPETRA_MPI_1: Added test (BASIC, NUM_MPI_PROCS=1, PROCESSORS=1)!
-- ShyLU_DDFROSch_test_thyra_xpetra_laplace_one_rank_TLP_IPOU_DIM3_TPETRA_MPI_1: Added test (BASIC, NUM_MPI_PROCS=1, PROCESSORS=1)!
Processing enabled package: ShyLU (Libs, Tests, Examples)
Pr
jjellio commented 3 years ago

I'm guessing you need examples too

kyungjoo-kim commented 3 years ago

hahah.... it really sounds somethin wrong in the script. for now, I also exclude the examples when gtest is not enabled in the same PR.

kyungjoo-kim commented 3 years ago

Do you know who we can get help for the script ?

jjellio commented 3 years ago

I think what you need is modifications to the relevant cmake/Dependencies.cmake files E.g., https://github.com/trilinos/Trilinos/blob/master/packages/shylu/shylu_node/cmake/Dependencies.cmake

./packages/shylu/shylu_dd/bddc/cmake/Dependencies.cmake:3:SET(TEST_REQUIRED_DEP_PACKAGES Gtest)
./packages/shylu/shylu_node/tacho/cmake/Dependencies.cmake:3:SET(TEST_REQUIRED_DEP_PACKAGES Kokkos KokkosAlgorithms Gtest)

I wonder if the problem is Gtest is a TPL not a Package. E.g., use SET(TEST_REQUIRED_TPLS Gtest) Since that other stuff is already there, maybe try adding the prior (and leaving the other) - the delete if the prior fixes it.

From: https://tribits.org/doc/TribitsDevelopersGuide.html#how-to-add-a-new-tribits-tpl-dependency

I can try mucking around with that if you want

kyungjoo-kim commented 3 years ago

If you can play with the cmake, I appreicate it. Somehow I cannot reproduce it when I just use my build script and the ATDM build script does not work either on my test bed machine. If that solves the problem, that is the best solution I think.

jjellio commented 3 years ago

Hm, tried it - and cmake dies because Gtest is disabled and it thinks it needs to be enabled ! (Clearly neither of us understands what to do =p)

I'm gonna keep your patches for now, because they let it work. I guess the other option would be to not use EMPIRE's script and use SPARC (they keep gtest) - then your code would get tested (which is the point)

kyungjoo-kim commented 3 years ago

BTW, how come it ends up enabling this pacakges ? When I see the atdm empire cmake, it enables mostly discretization packages.

[kyukim @kokkos-dev-2] empire > cat  EMPIRETrilinosPackagesList.cmake
SET(EMPIRE_Trilinos_Packages
  Panzer
  SEACASExodiff
  SEACASEpu
  SEACASNemspread
  SEACASNemslice
  SEACASAprepro
  Anasazi
  )

Another potential solution is to add Gtest to EMPIRE script. The addition itself should be okay although it can enables a lot of tests which used to disabled by Gtest. The whole point is to maintain the correctness of the code. So, enabling Gtest itself is not a bad idea.

jjellio commented 3 years ago

No you can't enable. There's a problem with EMPIRE (the actual code base) they bring their own Gtest, so if Trilinos adds it, EMPIRE breaks. Sparc (I believe) uses Trilinos for Gtest (or some game like that) - enabling it for one, breaks the other.

Hopefully that gets fixed at some point, then Sparc and EMPIRE will have nearly identically trilinos builds.

I don't know why the problem happens - my guess it has to do with most people enabling Gtest, and i'm being an outlier and use EMPIRE instead of SPARC - even though I think I could use either

jjellio commented 3 years ago

I'm inclined to build w/sparc's settings instead, because it would give better testing

jjellio commented 3 years ago

I swappd to sparc, with has Gtest - your Tacho and shylu stuff works fine that way.

I dunno what to do with this. Your patches do work at resolving Gtest = OFF issues. maybe commit them? I can click approve if you want to go that route.

It's not worth our time =p

kyungjoo-kim commented 3 years ago

Since the emphire script exist there, someone might just try the script. It will be better include the modification. It does not change the logic but it just expresses the logic more explicitly. Let's add it.

kyungjoo-kim commented 3 years ago

Closing this issue with PR merged.