Zoltan2: graph model built twice when doing distributed coloring

[kddevin]

Bug Report

@trilinos/zoltan2

Description

The GraphModel is built twice when doing distributed coloring; the first build is not needed.

Current code:

• ColoringProblem builds local GraphModel (on-rank graph)
• ColoringProblem chooses coloring method among SerialGreedy, D1, D2, PD2, D1-2GL
• Method SerialGreedy takes the local GraphModel as input
• Methods D1, D2, PD2, D1-2GL do not take the local GraphModel; instead, they build their own distributed GraphModel from the user's Adapter.

Proposed code:

• ColoringProblem chooses coloring method among SerialGreedy,, D1, D2, PD2, D1-2GL
• Method SerialGreedy builds a localGraphModel from the user's Adapter
• Methods D1, D2, PD2, D1-2GL build a distributed GraphModel from the user's Adapter

Pros: The proposed code removes algorithmic details from the ColoringProblem, and removes an extra copy of the local data (the local GraphModel) when distributed coloring is called

Cons: The proposed solution eliminates the possibility of re-using the local GraphModel within a ColoringProblem (though I don't think any Zoltan2 methods reuse the model at present).

Steps to Reproduce

If you put print statements for the localGraph and non localGraph construction in the GraphModel, you can see that, when running coloring1.cpp with colorMethod=D1, two GraphModels are built.

[github-actions[bot]]

This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity. If you would like to keep this issue open please add a comment and/or remove the MARKED_FOR_CLOSURE label. If this issue should be kept open even with no activity beyond the time limits you can add the label DO_NOT_AUTOCLOSE. If it is ok for this issue to be closed, feel free to go ahead and close it. Please do not add any comments or change any labels or otherwise touch this issue unless your intention is to reset the inactivity counter for an additional year.

[github-actions[bot]]

This issue was closed due to inactivity for 395 days.