Open bartlettroscoe opened 3 years ago
This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity.
If you would like to keep this issue open please add a comment and/or remove the MARKED_FOR_CLOSURE
label.
If this issue should be kept open even with no activity beyond the time limits you can add the label DO_NOT_AUTOCLOSE
.
If it is ok for this issue to be closed, feel free to go ahead and close it. Please do not add any comments or change any labels or otherwise touch this issue unless your intention is to reset the inactivity counter for an additional year.
FYI: Kitware is adding build stats support to native CMake, CTest, and CDash. See:
https://gitlab.kitware.com/cmake/cmake/-/issues/26247 Therefore, I think there will be no need for a separate compiler wrapper tool to gather build stats or scripts to manage that and submit it to CDash.
CC: @jjellio
Follow-up todos from #7376.
Additional things that might be nice to do:
magic_wrapper.py
and supporting code.magic_wrapper.py
file and any other needed files as well and installbuild_stats_<op>_wrapper.sh
scripts specifically for the install dir (to make build wrappers independent from the build and source trees). (This will make these scripts usable by downstream projects like SPARC and EMPIRE.)*.timing
files for theclean
target (see CMake directory property ADDITIONAL_MAKE_CLEAN_FILES and new ADDITIONAL_CLEAN_FILES).summarize-build-stats
(not attached toALL
) that will callsummarize-build-stats.py
with the right arguments and will write a filesummarized_build_stats.txt
(or even a JSON version of this?). That would make it super easy for developers to get summaries of build stats while doing local development. (In #8638)gather-build-stats
target to only include*.timing
files that match object files, libraries, and exectuables that are currently part of the build system (and not just lying around from an older version of Trilinos or previous builds of Trilinos).Add variablesNot sure if this is a good ideaTrilinos_<LANG>_BUILD_STATS_COMPILER_WRAPPER
toTrilinosConfig.cmake
so that downstream customers could set those toCMAKE_<LANG>_COMPLER
instead of the original unwrapped compilers listed inTrilinos_<LANG>_COMPILER
.TrilinosBuildStats_Results
output and sort them, plot them, write them into a*.json
file etc. (This is a cheaper way to get build summaries of build stands than having to download the entirebuild_stats.csv
files for each of these builds).build_stats.csv
file and display the results.tribits_ctest_driver(
) to support calling thectest_upload()
command:CTEST_UPLOAD_FILES
that will get uploaded to CDash once the build is complete.ctest_upload()
(called throughctest_upload_wrapper()
) gets called with the correct list of files .build_stats.csv
file usingctest_upload()
instead of (or in addition to) uploading it usingATTACHED_FILES
to a the testTrilinosBuildStats_Results
. (This will allow thebuild_stats.csv
file to get updated even if all tests are disabled.)