search

trilioData / tvk-plugins

kubectl plugins for logcollector and preflight checks tools
Other
2 stars 8 forks source link

🐛fix: Fix the logic to get the default volumeSnapshotClass #167

Closed josedev-union closed 1 year ago

josedev-union commented 1 year ago

fix #166

prasad-trilio commented 1 year ago

@josedev-union can you please check the CI job failures.

josedev-union commented 1 year ago

@josedev-union can you please check the CI job failures.

i checked but seems not related to my change?

prasad-trilio commented 1 year ago

@josedev-union there is one go lint failure due to your changes. Can you please fix that

Regarding the test job execution failures, due to organization restrictions, it won't be possible to run the jobs on this PR. We will raise a parallel PR with changes exactly same as yours, only to monitor the job status over there. But, this PR will be merged when everything looks good. In this way, we will preserve your contribution and monitor the jobs as well.

josedev-union commented 1 year ago

@josedev-union there is one go lint failure due to your changes. Can you please fix that

Regarding the test job execution failures, due to organization restrictions, it won't be possible to run the jobs on this PR. We will raise a parallel PR with changes exactly same as yours, only to monitor the job status over there. But, this PR will be merged when everything looks good. In this way, we will preserve your contribution and monitor the jobs as well.

@prasad-trilio thanks for this information. I tried to fix lll lint error. I ran the same lint command on my local and passed. Could you run CI again?

prasad-trilio commented 1 year ago

A parallel PR has been raised here

prasad-trilio commented 1 year ago

10/26 tests are failing. The tests need to be modified according to the changes done in this PR. We are tracking the progress of test-cases work here

prasad-trilio commented 1 year ago

thanks @josedev-union