search

trilioData / tvk-plugins

kubectl plugins for logcollector and preflight checks tools
Other
2 stars 8 forks source link

Merged few suggestions #88

Closed trilio-nikita closed 2 years ago

trilio-nikita commented 2 years ago
  1. Update shebang #!/bin/bash to #!/usr/bin/env bash and #!/usr/bin/python3 to #!/usr/bin/env python3 - Done
  2. Instead of helm repo update, use specific repo names to update helm repo update - "helm repo update" accepts no arguments
  3. Update operator_version and triliovault_manager_version default values - Done
  4. If $tvk_ns namespace creation failed then, return error or use default ns - Done
  5. Update TrilioVaultManager CR yaml. Check gitbooks, it thinks it has updated one. - Done
  6. Add variable for k8s-triliovault-ingress-gateway and reuse it. - Done