search

trilitech / tezos-developer-docs

Tezos Developer Docs (beta)
https://docs.tezos.com
MIT License
7 stars 13 forks source link

update Baking with the possibility of staking #463

Open NicNomadic opened 1 month ago

NicNomadic commented 1 month ago

This PR introduces the possibility of staking in the page explaining baking and delegation.

/assign @germanD

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-staging ✅ Ready (Inspect) Visit Preview Nov 20, 2024 6:00pm
NicNomadic commented 1 month ago

@germanD can you please review this?

timothymcmackin commented 2 weeks ago

Should we merge the Delegation topic in the smart contract section with this info? https://docs.tezos.com/smart-contracts/delegation

NicNomadic commented 2 weeks ago

Should we merge the Delegation topic in the smart contract section with this info? https://docs.tezos.com/smart-contracts/delegation

I think it's better to keep these pages separate, not to introduce confusion between the user choices, on one hand, and the more limited choices smart contracts have (only delegation).

In turn, that page's title should surely be changed to something more specific, such as "Smart contracts and delegation", "Delegation for smart contracts", or so.

timothymcmackin commented 2 weeks ago

I think it's better to keep these pages separate

Ok, I will address in a separate PR.

I have rebased this branch and I'm happy with it. Awaiting @germanD's review.

NicNomadic commented 2 weeks ago

@germanD I replaced the notion of "active stake" by "baking power" and "voting power", please check if it's all right now.

NicNomadic commented 1 week ago 
Reward factor | 2x | 1x

This is not true for several reasons, but mainly because delegation guarantees no reward whatsoever. More correct:

Increase voting power | 100% | 100%
Increase baking power | 100% | 50%
NicNomadic commented 1 week ago

I had another look at this PR vs. mine as we discussed and I think most of my info is covered here.

Except the changes to docs/overview/tezos-different.md in #366, isn't it?

timothymcmackin commented 1 week ago

I had another look at this PR vs. mine as we discussed and I think most of my info is covered here.

Except the changes to docs/overview/tezos-different.md in #366, isn't it?

Ok, added that here: https://github.com/trilitech/tezos-developer-docs/pull/463/commits/e435a889f9d221d6cc41fa144c446435553e7721