search

trill-lang / trill

A type safe, compiled language inspired by (and written in) Swift
MIT License
275 stars 15 forks source link

String Interpolation #52

Closed segiddins closed 7 years ago

segiddins commented 7 years ago

This is broken and I don't know why ¯_(ツ)_/¯

harlanhaskins commented 7 years ago

This is some fantastic work, and I am SO excited to merge this.

segiddins commented 7 years ago

https://github.com/trill-lang/trill/pull/52/commits/99811bae835f9e380299e703c579edcae9e3cf30 is optional, it will have a major performance downside

harlanhaskins commented 7 years ago

It certainly will, but I think that's actually fine. Constructing a temporary string isn't the end of the world.

segiddins commented 7 years ago

Failing due to the segfault @CodaFi wanted to look into

CodaFi commented 7 years ago

I think the crashes you're seeing here are actually caused by this patch. If it were LLVM you'd see it in the frames.

segiddins commented 7 years ago

They're happening when disposing the module, I'm pretty sure

CodaFi commented 7 years ago

It would go through LLVMDisposeModule like the others if that were true.

segiddins commented 7 years ago

It's being caught in the signal handler...

harlanhaskins commented 7 years ago

@trill-ci please test

segiddins commented 7 years ago

@trill-ci please pass

harlanhaskins commented 7 years ago

Uh...this should probably be reduced and filed on lira.

segiddins commented 7 years ago

I need to do reading tonight and go to bed and tbh I have no idea where to start with reduction

harlanhaskins commented 7 years ago

🎉 🎉 :tada: