Rendering system and other graphical improvements

Meisaka commented 3 years ago

This an in-progress work, I have yet to write some significant parts of it. I mainly would like any feedback on what I have so far

Description

Many of these changes are focused on streamlining, clean-up, and moving towards data-driven design in the Rendering system and it's components.

shaders files load from a json metadata file
point lights work properly
depth buffering was redone a bit to hopefully improve overall long-range precision
fixed some bugs in the OBJ loader
addtion of flexible vertex formats, for great memory savings and performance gains (maybe)

Motivation and Context

These are some of the larger objectives and plans:

Make better use of buffers and textures, pack things together and such.
Improve overall rendering quality, performance, and visual features.
Offer multiple quality/performance settings that can be switched at runtime.
Connect Lua to shaders to adjust uniforms or other parameters on the fly.
Add a few more shaders to improve the look of in-game screens and surface materials.
Possibly add shadows and other projection features.

How Has This Been Tested?

It runs on one of my machines :fox_face: :tada:

Screenshots (if appropriate):

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

adam4813 commented 3 years ago

Fair enough, that's why I asked.

On Mon, Aug 9, 2021, 6:00 PM Meisaka Yukara @.***> wrote:

@.**** commented on this pull request.

In client/render-system.hpp https://github.com/trillek-team/tec/pull/234#discussion_r685575847:

@@ -46,6 +47,8 @@ class RenderSystem :

void Update(const double delta);

bool HasExtension(const std::string& x) const { return extensions.find(x) != extensions.cend(); }

OpenGL extensions, nothing to do with files.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/trillek-team/tec/pull/234#discussion_r685575847, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAW7KTPKCOWEHC3X7DWQYNTT4BM2JANCNFSM5B2CPTXQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

adam4813 commented 3 years ago

It maybe best to merge this now before it gets much bigger in scope.

Meisaka commented 3 years ago

I think I will check to make sure this runs properly on multiple platforms, then see about merging it. Some of the other changes I want to add do start to leave the original scope.

trillek-team / tec