Closed adam4813 closed 2 years ago
@elantzb I cannot mark you as a reviewer, but tagging you here
Update this to use latest c++ language standard.
I recommend updating the description on the PR/commit to be more verbose. For the sake of a paper trail if needed in the future.
This will require https://github.com/protocolbuffers/protobuf/pull/10232 to be merged into a new version and the the version needs to be put on VCPKG and the baseline commit hash needs to be updated.
Visual studio 2017 is not supported any longer it appears due to sol2 https://github.com/ThePhD/sol2/issues/1362
Prior run was successful and the final commit should have skipped run as it was a typo fix to the README. I am going to merge this via admin powers instead of waiting.
Change to use CMake presets and update documentation generation, and the README, along side various bug fixes.
Description
Update README and added docs generation targets.
Fix readthedoc setup by including python requirements.
Update vcpkg commit hash for dependencies.
Change to use CMake presets with ninja multi config.
Fix asset failing to load missing null pointer check for animation.cpp.
Some adjustments to fmt.
Fix Dead ImGUI root window id being empty.
Add EOL find utility for md5anim and obj parsing. This should be replaced by a better check @elantzb .
Add better validation to md5anim parsing.
Remove explicit default constructor for Mesh.hpp Vertex
Update CMake min version to 19.
Fix include in pxiel-buffer.cpp being nested under tec namespace. The compiler was errantly looking for tec::std::man because of this.
Add launch config for vscode.
Properly set c++17 via target_compile_features interface to propagate
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: