search

trilliumeng / orion-sdk

Public SDK and ICD for Trillium Engineering's Orion Gimbals.
http://www.trilliumeng.com
MIT License
18 stars 15 forks source link

VideoPlayer Makefile breaks cross-compilation builds due to override of build flags #4

Closed John-Ingersoll closed 5 years ago

John-Ingersoll commented 5 years ago

The Makefile for the video player contains:

LDFLAGS=-lavcodec -lavformat -lavutil -lswscale -ljpeg
CFLAGS=-D_GNU_SOURCE

This removes any commandline provided options for these variables. This breaks the build process on cross-compilation systems. The assignment should be an append not an override.

jefffisher commented 5 years ago

Done – see 381168e

John-Ingersoll commented 5 years ago

Thank you for the quick turn. I was able to rebuild against this update with fewer issues.

You may want to consider making the examples as a different make target so that we can build the library without the examples from a clean clone.

On Tue, Oct 23, 2018 at 5:05 PM jefffisher notifications@github.com wrote:

Done – see 381168e https://github.com/trilliumeng/orion-sdk/commit/381168efa21a2bf82f1987f39f0332b6da24faea

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/trilliumeng/orion-sdk/issues/4#issuecomment-432419459, or mute the thread https://github.com/notifications/unsubscribe-auth/AKVLvrBJYQJn0hHok9bV3u54HPi9BPu6ks5un4SjgaJpZM4X2pI1 .

jefffisher commented 5 years ago

I'd be happy to add that; alternatively, if you just want to rework the makefiles as you see fit and submit a pull request, that works for me too.