trilogy-libraries / activerecord-trilogy-adapter

Active Record adapter for the Trilogy database client for Rails v6.0 - v7.0.
https://github.com/trilogy-libraries/trilogy
MIT License
171 stars 17 forks source link

Call `super` in `TrilogyAdapter#disconnect!` #11

Closed adrianna-chang-shopify closed 1 year ago

adrianna-chang-shopify commented 1 year ago

This way, we clear caching, reset transactions, and set @raw_connection_dirty to nil whenever #disconnect! is called. All of the other adapters in Rails call super, so I'm assuming this was an oversight, but please correct me if there's a reason we're not doing this currently.

Let me know if you'd prefer explicit tests for this, or if we're happy to rely on the upstream tests for this.