trilogy-libraries / activerecord-trilogy-adapter

Active Record adapter for the Trilogy database client for Rails v6.0 - v7.0.
https://github.com/trilogy-libraries/trilogy
MIT License
171 stars 17 forks source link

Translate new error classes #24

Closed adrianna-chang-shopify closed 1 year ago

adrianna-chang-shopify commented 1 year ago

Related to: https://github.com/github/trilogy/pull/15

Updates the adapter code to work with the changes made to Trilogy's error classes (see above PR). The diff is pretty minimal -- we change DatabaseError to ProtocolError in a couple of spots, and the base Trilogy::Error is now Trilogy::BaseError.

Curious about the release process -- do we make the changes to the Trilogy Ruby bindings, release a new version X, and then merge these changes in a new version of activerecord-trilogy-adapter that specifies X as the minimum required version for trilogy?

cc @composerinteralia @casperisfine