trilogy-libraries / activerecord-trilogy-adapter

Active Record adapter for the Trilogy database client for Rails v6.0 - v7.0.
https://github.com/trilogy-libraries/trilogy
MIT License
171 stars 17 forks source link

Incorporate Rails PR #48054 (Review me first!!) #48

Closed lorint closed 1 year ago

lorint commented 1 year ago

(This also attempts to have all method placement and naming to be as similar as possible to how things are laid out with the Trilogy adapter implementation found in Rails 7.1)

Per @casperisfine:

Stop using #execute as an internal method as it forces us to expose private parameters that aren't properly documented.

Also do some minor cleanup in the recently merged TrilogyAdapter to make it more consistent with other adapters.