search

trilogy-libraries / activerecord-trilogy-adapter

Active Record adapter for the Trilogy database client for Rails v6.0 - v7.0.
https://github.com/trilogy-libraries/trilogy
MIT License
171 stars 17 forks source link

correct reference to materialize_transactions in with_trilogy_connection #61

Closed dhruvCW closed 1 year ago

dhruvCW commented 1 year ago

inside the method we need to be explicit that we are calling materialize_transactions the method and not materialize_transactions the keyword argument.

this fixes https://github.com/trilogy-libraries/activerecord-trilogy-adapter/issues/60

dhruvCW commented 1 year ago

cc @bensheldon & @lorint

dhruvCW commented 1 year ago

gentle bump @bensheldon, anything I might be missing to merge this ?

bensheldon commented 1 year ago

Thank you for the PR! This fix has been released: https://github.com/trilogy-libraries/activerecord-trilogy-adapter/releases/tag/v3.1.2

lorint commented 1 year ago

@dhruvCW - Thank you very much for helping to make Trilogy everything that it is. For the encouragement early-on some months ago when these things were forming. For your continued involvement.

Thank you!