Closed wildmaples closed 5 months ago
I created an issue on the MySQL docker repo to see if they'd be open to building and tagging a mysql-community-test
variant that we can use. If they do, we can switch to that and get the test auth plugin for free. If they don't, we can keep what we have (checked-in plugins for various mysql version), or build our own MySQL image.
Would you mind squashing your commits?
I do like a clean git history, but we haven't historically been as opinionated about this as (for example) Rails.
Thank you!
Resolves: https://github.com/trilogy-libraries/trilogy/issues/157 Redo of: https://github.com/trilogy-libraries/trilogy/pull/168
The server doesn't request for cleartext plugin in the first handshake as it is not a default plugin. The client should only provide cleartext password when the server requests an auth switch to it, and the client has
enable_cleartext_plugin
option enabled. If the client does not have cleartext auth plugin enabled, we will raise aTrilogy::AuthPluginError
.This is the authentication flow for a server that uses the cleartext client side plugin (https://github.com/trilogy-libraries/trilogy/pull/168#discussion_r1548811735):
This PR introduces these changes:
cc: @ngan @composerinteralia