Closed ngan closed 5 months ago
Thank you for doing this cleanup!
What would you think about moving this under the /test
directory? I think that might make it clearer that this is build/test harness related and not something that's specifically functional to the library itself.
@bensheldon I debated that myself! No objections from me. Done.
I didn't see the Dockerfile.mysql
referenced in any of the other local development scripts 👍🏻
Yup. All for CI
Simple housekeeping change to move all mysql-related build files into
test/mysql/
. Improvements this gives us:docker-entrypoint-initdb.d
andDockerfile.mysql
..cnf
file that gets automatically loaded at MySQL boot (conf.d/build.cnf
). This gives us a lot of space so that we can start adding comments as to why we are setting various configurations. As we start adding more MySQL options to thecommand
,docker-compose.yml
becomes too cluttered.Dockerfile
without sacrificing clarity.