search

trilogy-libraries / trilogy

Trilogy is a client library for MySQL-compatible database servers, designed for performance, flexibility, and ease of embedding.
MIT License
697 stars 68 forks source link

Compartmentalize mysql-related files #178

Closed ngan closed 5 months ago

ngan commented 5 months ago

Simple housekeeping change to move all mysql-related build files into test/mysql/. Improvements this gives us:

  1. Cleans up the root directory by removing docker-entrypoint-initdb.d and Dockerfile.mysql.
  2. Move MySQL configurations into a .cnf file that gets automatically loaded at MySQL boot (conf.d/build.cnf). This gives us a lot of space so that we can start adding comments as to why we are setting various configurations. As we start adding more MySQL options to the command, docker-compose.yml becomes too cluttered.
  3. We can now rename our MySQL Dockerfile to just plain ol' Dockerfile without sacrificing clarity.
bensheldon commented 5 months ago

Thank you for doing this cleanup!

What would you think about moving this under the /test directory? I think that might make it clearer that this is build/test harness related and not something that's specifically functional to the library itself.

ngan commented 5 months ago

@bensheldon I debated that myself! No objections from me. Done.

bensheldon commented 5 months ago

I didn't see the Dockerfile.mysql referenced in any of the other local development scripts 👍🏻

ngan commented 5 months ago

Yup. All for CI