trilom / file-changes-action

This action can be added, and you will get outputs of all of the files that have changed in your repository for you to use.
MIT License
167 stars 48 forks source link

fix: Using platform-agnostic `homedir()` as output dir #124

Open james-braund opened 3 years ago

james-braund commented 3 years ago

Type of Change

Resolves

Describe Changes

Switched out platform-specific process.env.HOME for platform agnostic os.homedir().

Haven't adjusted unit tests, as they still feel appropriate. You could make the argument that we should mock the response from os.homedir() instead of allowing a real call to the underlay environment variables, but that would require some fairly significant refactoring of the tests.