Fixes crash on `renamed` file change status

trilom / file-changes-action

This action can be added, and you will get outputs of all of the files that have changed in your repository for you to use.

MIT License

167 stars 48 forks source link

Fixes crash on `renamed` file change status #98

Closed kaineer closed 4 years ago

kaineer commented 4 years ago

Type of Change

[ ] New feature
[x] Bug fix
[ ] Documentation
[ ] Refactor
[ ] Chore

Resolves

Fixes #93

Describe Changes

Adds an array changedFiles.renamed for files that were renamed. Hopefully it will help.

(May be it should check for old filename also?)

trilom commented 4 years ago

tyftc

I will review this today.

kaineer commented 4 years ago

@trilom Looks I just cannot improve it more. Will you fix the rest?

trilom commented 4 years ago

Thank you!

I can handle from here, appreciate!

trilom commented 4 years ago

I haven't cracked open this book in a minute, but I think the integration tests are failing because of how the action is running.

When running from an outside PR it doesn't have a token, so when it runs the integration tests it needs a token to do api requests. I don't recall if it can use the Action runner token or why it's that way, but it's not you.